Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require test manifest path for running tests #1228

Closed
Tracked by #604
tianleh opened this issue Dec 2, 2021 · 4 comments · Fixed by #1229
Closed
Tracked by #604

Require test manifest path for running tests #1228

tianleh opened this issue Dec 2, 2021 · 4 comments · Fixed by #1229
Assignees
Labels

Comments

@tianleh
Copy link
Member

tianleh commented Dec 2, 2021

Is your feature request related to a problem? Please describe

#604

Describe the solution you'd like

require test manifest path for running tests

Describe alternatives you've considered

No response

Additional context

No response

@tianleh tianleh added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Dec 2, 2021
@tianleh tianleh self-assigned this Dec 2, 2021
@tianleh tianleh changed the title require test manifest path for running tests Require test manifest path for running tests Dec 2, 2021
@tianleh
Copy link
Member Author

tianleh commented Dec 2, 2021

Also move the test manifest files from src to manifests

@dblock
Copy link
Member

dblock commented Dec 2, 2021

@tianleh No need to make new issues for things you're already putting PRs up for or very close to :) less work for you

@tianleh tianleh removed the untriaged Issues that have not yet been triaged label Dec 3, 2021
@tianleh
Copy link
Member Author

tianleh commented Dec 3, 2021

Thanks for the suggestion. I originally created this issue because the effort seemed non-trivial. Also I am keeping practicing my ability to realize such phased changes in advance. With such tracking (or "backfilling") exercise, I can always look back later as self retrospective of task breakdown when I need to create tasks for a group of engineers.

If it is the label "untriaged" which may attract the team' attention to groom the issue, I can quickly remove such label post creation.

@tianleh
Copy link
Member Author

tianleh commented Dec 3, 2021

I have been maintaining the overall picture of the task breakdown in this issue #604 (scroll down a bit from the top)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants