-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Persian stem token filter #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please write a test for it and add to CHANGELOG.
Changes AnalysisCommit SHA: ae4c817 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10030140918/artifacts/1726028949 API Coverage
|
Signed-off-by: Ebrahim Byagowi <ebrahim@gnu.org>
@dblock Added the changelog 😊 I'm yet figuring out how to add a test as there is not any test for any other filter as far as I can see |
Yes, appreciate if you could write some for other filters as well, start with something simple and work from there. We have a testing guide: https://github.com/opensearch-project/opensearch-api-specification/blob/main/TESTING_GUIDE.md, too. Since this is in the next version you will have to bump the docker hub ref in CI as well, https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml#L29. |
Finishing this in #592. |
Description
Add Persian stem token filter API documentation
Issues Resolved
Related to opensearch-project/OpenSearch#14847
This is based on PorterStemTokenFilter
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.