-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tools/linter
along with jest tests.
#219
Conversation
Signed-off-by: Theo Truong <theotr@amazon.com>
API specs implemented for 246/649 (37%) APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
- Add the linter build/test to CI part of this commit (even if you want to add linting itself as part of another), so future changes to the linter are tested.
- How much of the linter is OpenSearch-specific? Longer term, I wonder if it should be built as its own project in its own repo.
@dblock Half of the validator rules are OpenSearch specific:
The other rules enforce the multi-file structure we created for OpenSearch (divinding paths into namespaces in schemas into categories). The merger tool assumes that there are no infractions in these rules to ensure that the result single-file is a valid OpenAPI file. Projects that want to reuse this structure will benefit from these (Though the namespace is actually a part of |
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
API specs implemented for 246/649 (37%) APIs. |
Signed-off-by: Theo Truong <theotr@amazon.com>
API specs implemented for 246/649 (37%) APIs. |
Description
Added a Linter to validate all
yaml
files in the/spec
folderIssues Resolved
#205
(Not closing as we still need to turn this into a workflow with a follow-up PR)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.