Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Metric chart support in event analytics #872

Closed
ruchika-narang opened this issue Jul 19, 2022 · 6 comments
Closed

[FEATURE]: Metric chart support in event analytics #872

ruchika-narang opened this issue Jul 19, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ruchika-narang
Copy link
Contributor

  1. Add metric chart as a dropdown option.
  2. On selection of it, it should render a metric chart based on the aggregate function selected by user.
@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric , @btzeng

I have begun working on metric chart and I have taken reference from the dashboard. I have few questions related to it.

  1. Do we have to include the sibling pipeline aggregate functions in the dropdown of aggregate function as in the below screenshot?

aggregate_function

  1. There is a split group section inside bucket. Do we have to include that as in screenshot?

metric_bucket

Please let me know if I am going in the right direction for metric chart implementation and we need a similar implementation as dashboard.

Thanks,
Ruchika

@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric @btzeng @anirudha

I have started to work on Metrics chart. Currently we have included its basic implementation, which displays a single calculated value on the basis of chosen aggregate function and the UI looks as follows.
metrics_chart

A user can select more metrics also and it will be displayed in the same fashion along with other selected values. The reference for its implementation is from dashboard. Can you please confirm if the UI looks good to you.

I have a few questions with related to it which are asked in the above comment. Can you please clarify them as well!

Thanks,
Ruchika

@ruchika-narang
Copy link
Contributor Author

Hi @mengweieric , @btzeng , @anirudha

Following is the basic implementation of metrics chart. Let me know if we to need to make any changes here.

metrics_chart.mp4

Thanks,
Ruchika

@SivaprasadAluri
Copy link
Contributor

SivaprasadAluri commented Aug 19, 2022

Hi @mengweieric , @btzeng , @anirudha

Following is the implementation of metrics chart. That includes color Theme, Title and Font size panel, Let me know if we need to make any changes here.

Metrics1.mp4

Thanks
Sivaprasad

@mengweieric mengweieric added v2.4.0 'Issues and PRs related to version v2.4.0' and removed v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 6, 2022
@SivaprasadAluri
Copy link
Contributor

SivaprasadAluri commented Oct 11, 2022

Hi @mengweieric , @anirudha

Following is the implementation of metrics chart. Please let me know if any changes are needed.

Metrics2.mp4

Thanks
Sivaprasad

CC: @ruchika-narang

@ruchika-narang
Copy link
Contributor Author

Closing this one as renaming Stats to metrics. So this ticket is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants