Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Observability Visualization to Notebooks #307

Closed
ps48 opened this issue Dec 8, 2021 · 1 comment
Closed

Add Observability Visualization to Notebooks #307

ps48 opened this issue Dec 8, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ps48
Copy link
Member

ps48 commented Dec 8, 2021

Is your feature request related to a problem? Please describe.
Currently notebooks component only support adding Opensearch Dashboards visualization in a note. Visualizations made using Event analytics cannot be added to notebooks.

Describe the solution you'd like

  1. Add functionality to add Observability visualizations to notebooks UI.
  2. Modify the Panel-Visualization Container's react component to be flexible enough to be reused.

Describe alternatives you've considered
There are two ways to add Observability visualizations to notebooks:

  1. Use the panel grid component and add one visualization in it.
  2. Use only the visualization component to be added in notebooks.

Note: Approach "1" makes both type of visualizations have a common pattern, but this comes at a cost of rendering multiple fragments of react-grid-layout. This would make the page heavy to render. Therefore, Going with approach "2" to make the notebooks lightweight.

@ps48 ps48 added the enhancement New feature or request label Dec 8, 2021
@ps48 ps48 self-assigned this Dec 8, 2021
@ps48
Copy link
Member Author

ps48 commented Feb 7, 2022

Merged in #351

@ps48 ps48 closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant