-
Notifications
You must be signed in to change notification settings - Fork 186
[Refactor] Change stats collector job setting to be dynamic #4092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Change stats collector job setting to be dynamic #4092
Conversation
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4092 +/- ##
============================================
- Coverage 79.06% 79.05% -0.02%
Complexity 8621 8621
============================================
Files 755 756 +1
Lines 38352 38364 +12
Branches 4287 4289 +2
============================================
+ Hits 30324 30327 +3
- Misses 6220 6226 +6
- Partials 1808 1811 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can we add bit more tests: https://github.com/opensearch-project/ml-commons/pull/4092/checks?check_run_id=47862333944 |
dhrubo-os
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving to unblock you.
Zhangxunmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think it worth adding a log in the JobRunner runJob validation showing that "the job is disabled and it shouldn't be executed by JS".
…ering a disabled job Signed-off-by: Pavan Yekbote <pybot@amazon.com>
|
Thanks for the reviews! @dhrubo-os added more test cases @Zhangxunmt addressed the comment by adding a validation in job runner Once CI passes, can we merge and add backport labels for 3.2, 3.1? Thanks! |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.1 3.1
# Navigate to the new working tree
cd .worktrees/backport-3.1
# Create a new branch
git switch --create backport/backport-4092-to-3.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b6952b9d2ca7e0a7c42080d424ccb6d6c4d45e99
# Push it to GitHub
git push --set-upstream origin backport/backport-4092-to-3.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.1Then, create a pull request where the |
(cherry picked from commit b6952b9)
…ch-project#4092) (opensearch-project#4094) (cherry picked from commit b6952b9) Co-authored-by: Pavan Yekbote <pybot@amazon.com>
Description
This change allows a user to enable/disable the stats collector job dynamically without requiring a cluster restart
Related Issues
Resolves #4091
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.