-
Notifications
You must be signed in to change notification settings - Fork 186
enhance tool input parsing and add agentic rag tutorial #4023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ylwu-amzn can we separate the PRs for the fix and the blog? that way we can get the fix reviewed and merged first and get the tutorial merged slightly later |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4023 +/- ##
============================================
+ Coverage 80.64% 80.66% +0.02%
- Complexity 8023 8027 +4
============================================
Files 695 695
Lines 35058 35064 +6
Branches 3942 3943 +1
============================================
+ Hits 28271 28283 +12
+ Misses 5052 5044 -8
- Partials 1735 1737 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we add test? |
|
Tests are failing.
|
|
Can a maintainer add backport 3.1 label to this? |
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.1 3.1
# Navigate to the new working tree
cd .worktrees/backport-3.1
# Create a new branch
git switch --create backport/backport-4023-to-3.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 443a4057f518f13ebec57f80314859234d302527
# Push it to GitHub
git push --set-upstream origin backport/backport-4023-to-3.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.1Then, create a pull request where the |
…roject#4023) * enhance tool input parsing and add agentic rag tutorial Signed-off-by: Yaliang Wu <ylwu@amazon.com> * remove tutorial; add unit test Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix unit test Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com>
…roject#4023) * enhance tool input parsing and add agentic rag tutorial Signed-off-by: Yaliang Wu <ylwu@amazon.com> * remove tutorial; add unit test Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix unit test Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Description
Found the tool input parsing not correct when build tutorial for Agentic RAG.
Want to use this input template
"input": "{\"index\": \"${parameters.index}\", \"query\": ${parameters.query} }",for SearchIndexTool, but it will not substitute LLM generated input{"question": "Seattle 2025 population"}.The SearchIndexTool input will always be
{"question": "Seattle 2025 population"}, but we expect such inputRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.