-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Enhancement] Add schema validation and placeholders to index mappings #3310
base: 2.x
Are you sure you want to change the base?
Conversation
#3240) * feat(index mappings): fetch mappings and version from json file instead of string constants Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: changing exception being thrown Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * chore: remove unused file Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * chore: fix typo in comment Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * chore: adding new line at the end of files Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * feat: add test cases Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: remove test code Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix(test): in main the versions were not updated appropriately Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: move mapping templates under common module Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: ensure that conversationindexconstants reference mlindex enums rather than use their own mappings Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: update comment Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * feat: add enhancements to validate index schema and allow using placeholders Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: modifying comment Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * test: adding testcase for MLIndex to catch failures before runtime Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: rename dir from mappings to index-mappings Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: add null checks Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: modify mappin paths for placeholders Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: adding dependencies for testing Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix(test): compare json object rather than strings to avoid eol character issue Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: combine if statements into single check Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactoring: null handling + clean code Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * spotless apply Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * tests: adding more UT Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fix: dependencies to handle jarhell Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * spotless apply Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: add header and use single instance of mapper Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * fixed: doc syntax Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: renamed files, efficient loading of resources, better exception handling Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: cleaner comment Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> (cherry picked from commit 374cfd5)
rerunning BWC 11
|
@pyek-bot you need to add some code from this PR : https://github.com/opensearch-project/ml-commons/pull/2800/files In 2.x branch we don't have |
@dhrubo-os should we add backport label to this pr instead of making changes in mine Edit: nvm, the pr mentions why it was not backported to 2.x, i will manually introduced versions variable |
Raised a manual backport PR with the required changes: #3342 |
Backport 374cfd5 from #3240