Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky test of visualization tool (#2416) #2435

Conversation

Hailong-am
Copy link
Contributor

backport aa09014 from #2416

dhrubo-os
dhrubo-os previously approved these changes May 10, 2024
@Hailong-am
Copy link
Contributor Author

test case failures are related to PredictionITTests, looks like they are flaky also. I have create an issue to track #2436 and will fix it with another PR.

@Hailong-am
Copy link
Contributor Author

test case failures are related to PredictionITTests, looks like they are flaky also. I have create an issue to track #2436 and will fix it with another PR.

@ylwu-amzn @dhrubo-os can you help to review #2437 first, this should fix the flaky test of PredictionITTest and get it backport to 2.x, after that i will rebase this backport PR with 2.x

ylwu-amzn
ylwu-amzn previously approved these changes Jun 12, 2024
@ylwu-amzn
Copy link
Collaborator

This PR has conflicts, @Hailong-am Can you fix ?

* add wait for model to be undeployed

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* spotless

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update model undeploy status

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* reduce total wait time

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit aa09014)
@Hailong-am Hailong-am dismissed stale reviews from ylwu-amzn and dhrubo-os via d7b62e7 June 12, 2024 23:37
@Hailong-am Hailong-am force-pushed the backport/backport-2416-to-2.x branch from d8818d4 to d7b62e7 Compare June 12, 2024 23:37
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env June 12, 2024 23:37 — with GitHub Actions Failure
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 12, 2024 23:40 — with GitHub Actions Inactive
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env June 12, 2024 23:40 — with GitHub Actions Failure
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 12, 2024 23:41 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 12, 2024 23:41 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 12, 2024 23:41 — with GitHub Actions Inactive
@Hailong-am
Copy link
Contributor Author

This PR has conflicts, @Hailong-am Can you fix ?

this may not needed anymore as #2510 fix the undeploy issue. i will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants