fix CVE for org.eclipse.core.runtime #2378

mingshl · 2024-04-30T17:44:23Z

Description

The Spotless Gradle Plugin brings in a transitive dependency on Eclipse Core Runtime 3.26.100. That version is impacted by a CVE. This forces the newest version, currently 3.29.0.

Issues Resolved

#1863

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

dhrubo-os

Approved, but please make sure to merge after passing an integration test.

mingshl · 2024-04-30T21:00:28Z

there is a flaky test related to visualization tool

[2024-04-30T22:35:16,321][INFO ][o.o.m.t.VisualizationsToolIT] [testVisualizationNotFound] after test
REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=8D417CC63FEA4F0A -Dtests.security.manager=false -Dtests.locale=sk -Dtests.timezone=Asia/Tehran -Druntime.java=17

org.opensearch.ml.tools.VisualizationsToolIT > testVisualizationNotFound STANDARD_ERROR
    REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=8D417CC63FEA4F0A -Dtests.security.manager=false -Dtests.locale=sk -Dtests.timezone=Asia/Tehran -Druntime.java=17

org.opensearch.ml.tools.VisualizationsToolIT > testVisualizationNotFound FAILED

org.opensearch.client.ResponseException: method [DELETE], host [http://127.0.0.1:46451/], URI [/_plugins/_ml/models/7WNlMI8BA-goW0opkA9U], status line [HTTP/1.1 400 Bad Request]

Suite: Test class org.opensearch.ml.tools.VisualizationsToolIT
{"error":{"root_cause":[{"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"}],"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"},"status":400}
2> REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=8D417CC63FEA4F0A -Dtests.security.manager=false -Dtests.locale=sk -Dtests.timezone=Asia/Tehran -Druntime.java=17
at __randomizedtesting.SeedInfo.seed([8D417CC63FEA4F0A:4222D85B38D9750A]:0)
2> org.opensearch.client.ResponseException: method [DELETE], host [http://127.0.0.1:46451/], URI [/_plugins/_ml/models/7WNlMI8BA-goW0opkA9U], status line [HTTP/1.1 400 Bad Request]
at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:385)
{"error":{"root_cause":[{"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"}],"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"},"status":400}

@Hailong-am can you fix this flaky test?

Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d)

Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d) Co-authored-by: Mingshi Liu <113382730+mingshl@users.noreply.github.com>

Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d) Co-authored-by: Mingshi Liu <113382730+mingshl@users.noreply.github.com> (cherry picked from commit af63e5e)

Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d) Co-authored-by: Mingshi Liu <113382730+mingshl@users.noreply.github.com> (cherry picked from commit af63e5e) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>

Hailong-am · 2024-05-09T02:33:39Z

there is a flaky test related to visualization tool
[2024-04-30T22:35:16,321][INFO ][o.o.m.t.VisualizationsToolIT] [testVisualizationNotFound] after test
REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=8D417CC63FEA4F0A -Dtests.security.manager=false -Dtests.locale=sk -Dtests.timezone=Asia/Tehran -Druntime.java=17

org.opensearch.ml.tools.VisualizationsToolIT > testVisualizationNotFound STANDARD_ERROR
    REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=8D417CC63FEA4F0A -Dtests.security.manager=false -Dtests.locale=sk -Dtests.timezone=Asia/Tehran -Druntime.java=17
org.opensearch.ml.tools.VisualizationsToolIT > testVisualizationNotFound FAILED
org.opensearch.client.ResponseException: method [DELETE], host [http://127.0.0.1:46451/], URI [/_plugins/_ml/models/7WNlMI8BA-goW0opkA9U], status line [HTTP/1.1 400 Bad Request]
Suite: Test class org.opensearch.ml.tools.VisualizationsToolIT {"error":{"root_cause":[{"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"}],"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"},"status":400} 2> REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=8D417CC63FEA4F0A -Dtests.security.manager=false -Dtests.locale=sk -Dtests.timezone=Asia/Tehran -Druntime.java=17 at __randomizedtesting.SeedInfo.seed([8D417CC63FEA4F0A:4222D85B38D9750A]:0) 2> org.opensearch.client.ResponseException: method [DELETE], host [http://127.0.0.1:46451/], URI [/_plugins/_ml/models/7WNlMI8BA-goW0opkA9U], status line [HTTP/1.1 400 Bad Request] at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:385) {"error":{"root_cause":[{"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"}],"type":"status_exception","reason":"Model cannot be deleted in deploying or deployed state. Try undeploy model first then delete"},"status":400}

@Hailong-am can you fix this flaky test?

Raise #2416 to fix this flaky test

…earch-project#2380) Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d) Co-authored-by: Mingshi Liu <113382730+mingshl@users.noreply.github.com>

fix CVE for org.eclipse.core.runtime

3a054df

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

mingshl requested review from b4sjoo, dhrubo-os, jngz-es, model-collapse, rbhavna, ylwu-amzn, zane-neo, Zhangxunmt, austintlee, HenryL27, samuel-oci and xinyual as code owners April 30, 2024 17:44

mingshl temporarily deployed to ml-commons-cicd-env April 30, 2024 17:44 — with GitHub Actions Inactive

opensearch-trigger-bot bot added the infra label Apr 30, 2024

mingshl had a problem deploying to ml-commons-cicd-env April 30, 2024 17:44 — with GitHub Actions Error

mingshl had a problem deploying to ml-commons-cicd-env April 30, 2024 17:44 — with GitHub Actions Failure

dhrubo-os approved these changes Apr 30, 2024

View reviewed changes

jngz-es approved these changes Apr 30, 2024

View reviewed changes

mingshl temporarily deployed to ml-commons-cicd-env April 30, 2024 18:16 — with GitHub Actions Inactive

mingshl had a problem deploying to ml-commons-cicd-env April 30, 2024 18:16 — with GitHub Actions Error

mingshl had a problem deploying to ml-commons-cicd-env April 30, 2024 18:16 — with GitHub Actions Failure

mingshl had a problem deploying to ml-commons-cicd-env April 30, 2024 18:16 — with GitHub Actions Error

mingshl self-assigned this Apr 30, 2024

mingshl added the v2.14.0 label Apr 30, 2024

mingshl added the backport 2.x label Apr 30, 2024

mingshl merged commit aa3616d into opensearch-project:main Apr 30, 2024
11 of 14 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024

fix CVE for org.eclipse.core.runtime (#2378)

fc415da

Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d)

opensearch-trigger-bot bot mentioned this pull request Apr 30, 2024

[Backport 2.x] fix CVE for org.eclipse.core.runtime #2380

Merged

mingshl mentioned this pull request Apr 30, 2024

Flaky Test NeuralQueryEnricherProcessorIT #2381

Closed

mingshl added a commit that referenced this pull request Apr 30, 2024

fix CVE for org.eclipse.core.runtime (#2378) (#2380)

af63e5e

Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit aa3616d) Co-authored-by: Mingshi Liu <113382730+mingshl@users.noreply.github.com>

mingshl removed the infra label May 1, 2024

mingshl mentioned this pull request May 1, 2024

Add release note 2.14 #2387

Merged

5 tasks

mingshl added the maintenance label May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix CVE for org.eclipse.core.runtime #2378

fix CVE for org.eclipse.core.runtime #2378

mingshl commented Apr 30, 2024 •

edited

Loading

dhrubo-os left a comment

mingshl commented Apr 30, 2024

Hailong-am commented May 9, 2024

fix CVE for org.eclipse.core.runtime #2378

fix CVE for org.eclipse.core.runtime #2378

Conversation

mingshl commented Apr 30, 2024 • edited Loading

Description

Issues Resolved

Check List

dhrubo-os left a comment

Choose a reason for hiding this comment

mingshl commented Apr 30, 2024

Hailong-am commented May 9, 2024

mingshl commented Apr 30, 2024 •

edited

Loading