[Backport 2.x] Fixes #2317 predict api not working with asymmetric models #2359
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fixes #2317 predict api not working with asymmetric models Signed-off-by: br3no <breno@veltefaria.de> * Adding unit test code path for the parsing of the parameter. Signed-off-by: br3no <breno@veltefaria.de> * Removing involuntary import of guava Signed-off-by: br3no <breno@veltefaria.de> * Refactor package of AsymmetricTextEmbeddingParameters The MLCommonsClassLoader expects all MLAlgoParameters to be in the "org.opensearch.ml.common.input.parameter" package. Signed-off-by: br3no <breno@veltefaria.de> * fixing unit test after package refactoring Signed-off-by: br3no <breno@veltefaria.de> --------- Signed-off-by: br3no <breno@veltefaria.de> (cherry picked from commit 8425a65)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
|
@br3no for the next time, please make sure your email address is public, so that backport PRs doesn't fail with DCO like this time... |
dhrubo-os
approved these changes
Apr 25, 2024
|
Manually set DCO as passed |
ylwu-amzn
approved these changes
Apr 25, 2024
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
dhrubo-os
pushed a commit
to dhrubo-os/ml-commons
that referenced
this pull request
May 17, 2024
… models (opensearch-project#2318) (opensearch-project#2359) * Fixes opensearch-project#2317 predict api not working with asymmetric models Signed-off-by: br3no <breno@veltefaria.de> * Adding unit test code path for the parsing of the parameter. Signed-off-by: br3no <breno@veltefaria.de> * Removing involuntary import of guava Signed-off-by: br3no <breno@veltefaria.de> * Refactor package of AsymmetricTextEmbeddingParameters The MLCommonsClassLoader expects all MLAlgoParameters to be in the "org.opensearch.ml.common.input.parameter" package. Signed-off-by: br3no <breno@veltefaria.de> * fixing unit test after package refactoring Signed-off-by: br3no <breno@veltefaria.de> --------- Signed-off-by: br3no <breno@veltefaria.de> (cherry picked from commit 8425a65) Co-authored-by: Breno Faria <breno@veltefaria.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8425a65 from #2318