-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto deployment for remote models #2206
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2206 +/- ##
============================================
- Coverage 81.90% 81.64% -0.26%
- Complexity 5719 5720 +1
============================================
Files 547 547
Lines 23075 23148 +73
Branches 2378 2382 +4
============================================
Hits 18900 18900
- Misses 3230 3303 +73
Partials 945 945
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
@@ -32,10 +32,13 @@ | |||
@Log4j2 | |||
public class MLModelCacheHelper { | |||
private final Map<String, MLModelCache> modelCaches; | |||
|
|||
private final Set<String> localDeployedModels; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about use HashMap to avoid synchronized
, https://github.com/ylwu-amzn/ml-commons/blob/2x_autodeploy/plugin/src/main/java/org/opensearch/ml/model/MLModelCacheHelper.java#L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will refresh in the next commit.
plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Signed-off-by: Xun Zhang <xunzh@amazon.com>
* auto deployment for remote models Signed-off-by: Xun Zhang <xunzh@amazon.com> * add auto deploy feature flag Signed-off-by: Xun Zhang <xunzh@amazon.com> * add eligible node check and avoid over-deployment Signed-off-by: Xun Zhang <xunzh@amazon.com> * dispatch local deploy Signed-off-by: Xun Zhang <xunzh@amazon.com> --------- Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit b037032)
* auto deployment for remote models Signed-off-by: Xun Zhang <xunzh@amazon.com> * add auto deploy feature flag Signed-off-by: Xun Zhang <xunzh@amazon.com> * add eligible node check and avoid over-deployment Signed-off-by: Xun Zhang <xunzh@amazon.com> * dispatch local deploy Signed-off-by: Xun Zhang <xunzh@amazon.com> --------- Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit b037032) Co-authored-by: Xun Zhang <xunzh@amazon.com>
* auto deployment for remote models Signed-off-by: Xun Zhang <xunzh@amazon.com> * add auto deploy feature flag Signed-off-by: Xun Zhang <xunzh@amazon.com> * add eligible node check and avoid over-deployment Signed-off-by: Xun Zhang <xunzh@amazon.com> * dispatch local deploy Signed-off-by: Xun Zhang <xunzh@amazon.com> --------- Signed-off-by: Xun Zhang <xunzh@amazon.com>
Description
This PR is the minimum requirement for automatic deployment. When running a prediction for a remote model,
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.