Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anomaly localization integration step 4 and 5 #125

Merged
merged 1 commit into from
Jan 21, 2022
Merged

anomaly localization integration step 4 and 5 #125

merged 1 commit into from
Jan 21, 2022

Conversation

wnbts
Copy link
Contributor

@wnbts wnbts commented Jan 20, 2022

Signed-off-by: lai 57818076+wnbts@users.noreply.github.com

Description

This pr implements integration step 4 and 5 for anomaly localization.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wnbts wnbts requested a review from a team January 20, 2022 17:17
ylwu-amzn
ylwu-amzn previously approved these changes Jan 21, 2022
Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ylwu-amzn
Copy link
Collaborator

Build failed as

[ant:jacocoReport] Rule violated for class org.opensearch.ml.task.MLTaskManager: branches covered ratio is 0.7, but expected minimum is 0.8

MLTaskManager has been excluded, you can rebased and merge with main branch and confirm build can pass or not.

Signed-off-by: lai <57818076+wnbts@users.noreply.github.com>
@wnbts wnbts merged commit b4538c7 into opensearch-project:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants