Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bump ML config index schema version #2630

Closed
ylwu-amzn opened this issue Jul 9, 2024 · 3 comments
Closed

[BUG] bump ML config index schema version #2630

ylwu-amzn opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working v2.16.0 Issues targeting release v2.16.0

Comments

@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Jul 9, 2024

What is the bug?
ML config index mapping updated, but schema version not bumped. This PR #1995 updated

@ylwu-amzn ylwu-amzn added bug Something isn't working untriaged and removed untriaged labels Jul 9, 2024
@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Jul 9, 2024

Same for .plugins-ml-config index.

In 2.9 index mapping definition is:

{
  ".plugins-ml-config" : {
    "mappings" : {
      "_meta" : {
        "schema_version" : 2
      },
      "properties" : {
        "create_time" : {
          "type" : "date",
          "format" : "strict_date_time||epoch_millis"
        },
        "master_key" : {
          "type" : "keyword"
        }
      }
    }
  }
}

and in 2.13 it is:

{
  ".plugins-ml-config" : {
    "mappings" : {
      "dynamic" : "strict",
      "_meta" : {
        "schema_version" : 2
      },
      "properties" : {
        "configuration" : {
          "type" : "flat_object"
        },
        "create_time" : {
          "type" : "date",
          "format" : "strict_date_time||epoch_millis"
        },
        "last_update_time" : {
          "type" : "date",
          "format" : "strict_date_time||epoch_millis"
        },
        "master_key" : {
          "type" : "keyword"
        },
        "type" : {
          "type" : "keyword"
        }
      }
    }
  }
}

this PR updated

@ylwu-amzn
Copy link
Collaborator Author

Sorry my bad, it should be ML config index, not model group .

@ylwu-amzn ylwu-amzn changed the title [BUG] bump model group index schema version [BUG] bump ML config index schema version Jul 10, 2024
@dhrubo-os
Copy link
Collaborator

I found another PR: https://github.com/opensearch-project/ml-commons/pull/2276/files where version didn't get bumped.

@b4sjoo b4sjoo moved this to Untriaged in ml-commons projects Jul 16, 2024
@b4sjoo b4sjoo moved this from Untriaged to In Progress in ml-commons projects Jul 16, 2024
@ylwu-amzn ylwu-amzn added the v2.16.0 Issues targeting release v2.16.0 label Jul 16, 2024
@b4sjoo b4sjoo closed this as completed Jul 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.16.0 Issues targeting release v2.16.0
Projects
Development

No branches or pull requests

4 participants