Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for timeout in http connector #1470

Closed
austintlee opened this issue Oct 9, 2023 · 6 comments
Closed

[FEATURE] Support for timeout in http connector #1470

austintlee opened this issue Oct 9, 2023 · 6 comments
Labels
enhancement New feature or request v2.13.0 Issues targeting release v2.13.0

Comments

@austintlee
Copy link
Collaborator

Is your feature request related to a problem?
Occasionally, a request to OpenAI just sits for 10 minutes and fails with a "bad gateway" error.

What solution would you like?
I would like to specify the maximum amount of time an http connector should wait before it cancels a request.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@ylwu-amzn
Copy link
Collaborator

@zane-neo , Zan, since you built the http client factory, can you give some suggestion/solution for this?

@ylwu-amzn
Copy link
Collaborator

@zane-neo as you find other http client perfromance issue, can you create issue for tracking that?

@ylwu-amzn ylwu-amzn moved this to Untriaged in ml-commons projects Oct 20, 2023
@ylwu-amzn ylwu-amzn moved this from Untriaged to Backlog in ml-commons projects Oct 20, 2023
@zane-neo
Copy link
Collaborator

@zane-neo , Zan, since you built the http client factory, can you give some suggestion/solution for this?

I think we can let user configure these, including: connection timeout, read timeout, connection pool size etc, I will create a PR to address this.

@zane-neo
Copy link
Collaborator

@zane-neo as you find other http client perfromance issue, can you create issue for tracking that?

Found it here: #1537

@Zhangxunmt Zhangxunmt added bug Something isn't working and removed untriaged labels Oct 30, 2023
@austintlee
Copy link
Collaborator Author

#1835

@b4sjoo b4sjoo removed the bug Something isn't working label Jan 5, 2024
@mingshl mingshl closed this as completed Mar 12, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in ml-commons projects Mar 12, 2024
@ylwu-amzn ylwu-amzn added the v2.13.0 Issues targeting release v2.13.0 label Mar 20, 2024
@ylwu-amzn
Copy link
Collaborator

Done in this PR #1835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.13.0 Issues targeting release v2.13.0
Projects
Status: 2.13.0 (Launched )
Development

No branches or pull requests

6 participants