Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyright in README #76

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

jmazanec15
Copy link
Member

@jmazanec15 jmazanec15 commented Aug 6, 2021

Signed-off-by: John Mazanec jmazane@amazon.com

Description

Modify Copyright Description in README. I could not find other instances outside of the README.

Related: opensearch-project/.github#24

Issues Resolved

#75

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 added the bug Something isn't working label Aug 6, 2021
@jmazanec15 jmazanec15 changed the title Fix copyright Fix copyright in README Aug 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #76 (af0d751) into main (ff057f0) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #76      +/-   ##
============================================
- Coverage     82.70%   82.48%   -0.22%     
+ Complexity      476      474       -2     
============================================
  Files            69       69              
  Lines          1821     1821              
  Branches        178      178              
============================================
- Hits           1506     1502       -4     
- Misses          253      257       +4     
  Partials         62       62              
Impacted Files Coverage Δ
.../java/org/opensearch/knn/index/util/KNNEngine.java 89.47% <0.00%> (-5.27%) ⬇️
...n/java/org/opensearch/knn/index/KNNIndexCache.java 92.38% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff057f0...af0d751. Read the comment docs.

Signed-off-by: John Mazanec <jmazane@amazon.com>
vamshin
vamshin previously approved these changes Aug 6, 2021
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

VijayanB
VijayanB previously approved these changes Aug 6, 2021
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your NOTICE.txt doesn't match, it contains k-nn, which I think should be removed and replaced with just OpenSearch Contributors. I believe you should also remove ODFE references.

@jmazanec15
Copy link
Member Author

@dblock makes sense, will update.

Which ODFE references are you referring to? I see the one in the NOTICE.txt, but there are also the licenses in the code (I assume this is not what you are talking about).

Signed-off-by: John Mazanec <jmazane@amazon.com>
@dblock
Copy link
Member

dblock commented Aug 10, 2021

@dblock makes sense, will update.

Which ODFE references are you referring to? I see the one in the NOTICE.txt, but there are also the licenses in the code (I assume this is not what you are talking about).

I only meant OpenDistroForElasticsearch in the NOTICE

@jmazanec15 jmazanec15 merged commit 5963577 into opensearch-project:main Aug 10, 2021
jmazanec15 added a commit to jmazanec15/k-NN-1 that referenced this pull request Aug 10, 2021
jmazanec15 added a commit to jmazanec15/k-NN-1 that referenced this pull request Aug 10, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 mentioned this pull request Aug 10, 2021
1 task
@VijayanB VijayanB added the Bug Fixes Changes to a system or product designed to handle a programming bug/glitch label Sep 10, 2021
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants