-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copyright in README #76
Fix copyright in README #76
Conversation
Signed-off-by: John Mazanec <jmazane@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
============================================
- Coverage 82.70% 82.48% -0.22%
+ Complexity 476 474 -2
============================================
Files 69 69
Lines 1821 1821
Branches 178 178
============================================
- Hits 1506 1502 -4
- Misses 253 257 +4
Partials 62 62
Continue to review full report at Codecov.
|
Signed-off-by: John Mazanec <jmazane@amazon.com>
fad8eb6
to
0eac1e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your NOTICE.txt doesn't match, it contains k-nn, which I think should be removed and replaced with just OpenSearch Contributors. I believe you should also remove ODFE references.
@dblock makes sense, will update. Which ODFE references are you referring to? I see the one in the NOTICE.txt, but there are also the licenses in the code (I assume this is not what you are talking about). |
Signed-off-by: John Mazanec <jmazane@amazon.com>
I only meant |
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec jmazane@amazon.com
Description
Modify Copyright Description in README. I could not find other instances outside of the README.
Related: opensearch-project/.github#24
Issues Resolved
#75
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.