Update Build Script to build libraries with SIMD #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
|
@peterzhuamazon @prudhvigodithi Can you please review this PR |
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
update_build_script_simd
branch
from
05e20a9
to
bcc5e3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
============================================
- Coverage 85.07% 85.02% -0.06%
Complexity 1278 1278
============================================
Files 167 167
Lines 5207 5207
Branches 493 493
============================================
- Hits 4430 4427 -3
- Misses 570 573 +3
Partials 207 207 ☔ View full report in Codecov by Sentry. |
jmazanec15
approved these changes
Feb 5, 2024
vibrantvarun
approved these changes
Feb 5, 2024
peterzhuamazon
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Just reviewed with @naveentatikonda and I am ok with this change
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 8eb0776)
naveentatikonda
added a commit
that referenced
this pull request
Feb 5, 2024
naveentatikonda
added a commit
to naveentatikonda/k-NN
that referenced
this pull request
Feb 6, 2024
naveentatikonda
added a commit
to naveentatikonda/k-NN
that referenced
this pull request
Feb 6, 2024
…project#1451) (opensearch-project#1454)" This reverts commit d5b4237. Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
added a commit
that referenced
this pull request
Feb 6, 2024
martin-gaievski
added a commit
to martin-gaievski/k-NN
that referenced
this pull request
Feb 14, 2024
…project#1451)" This reverts commit 8eb0776.
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update build script to build and include both the versions of JNI libraries (with and without SIMD optimization) in the final artifact by creating two subdirectories
libandlib_simd.Issues Resolved
opensearch-project/opensearch-build#4386
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.