moved _doc_count field from rollup._doc_count to root of document #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
downsrob
approved these changes
Aug 2, 2022
|
Petar and I have independently confirmed that following this change, rollup doc_count values will be correct |
bowenlan-amzn
approved these changes
Aug 4, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 1f581dd)
bowenlan-amzn
pushed a commit
that referenced
this pull request
Aug 4, 2022
6 tasks
Angie-Zhang
pushed a commit
to Angie-Zhang/index-management
that referenced
this pull request
Sep 12, 2022
…ensearch-project#439) (opensearch-project#442) Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 1f581dd) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Angie Zhang <langelzh@amazon.com>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…ensearch-project#439) (opensearch-project#442) Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 1f581dd) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
…ensearch-project#439) (opensearch-project#442) Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> (cherry picked from commit 1f581dd) Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Dzepina petar.dzepina@gmail.com
Issue #, if available: 57
Description of changes:
After merging this _doc_count elasticsearch PR, now we have to move _doc_count to root of rollup doc, so that core picks it up and calculate doc_count correctly
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.