Fix flaky rollup test by stopping jobs before index cleanup #1530
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky because rollup job coroutines continued running after
test cleanup, causing a race condition where the config index was recreated
with incorrect dynamic mappings.
Root cause:
- Tests create enabled rollups -> JobScheduler schedules them
- RollupRunner.runJob() launches coroutines via launch {}
- Test @after wipes indices
- BUT coroutines are still running in background
- Coroutines write metadata AFTER indices wiped
- Index auto-creates with wrong dynamic mappings (long vs date)
- Next test fails with mapping conflict on rollup_metadata.continuous.next_window_end_time
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
bowenlan-amzn
force-pushed
the
fix-rollup-flaky-2
branch
from
4497be9 to
5bb31af
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 76.16% 76.12% -0.04%
==========================================
Files 375 375
Lines 17567 17567
Branches 2410 2410
==========================================
- Hits 13380 13373 -7
- Misses 2946 2949 +3
- Partials 1241 1245 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bowenlan-amzn
requested review from
Hailong-am,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failure: https://github.com/opensearch-project/index-management/actions/runs/19418611760/job/55551674679?pr=1455
The test was flaky because rollup job coroutines continued running after test cleanup, causing a race condition where the config index was recreated with incorrect dynamic mappings.
Root cause:
@Afterwipes indicesRelated Issues
Resolves #90
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.