Skip to content

Commit bdb5e84

Browse files
committed
Fix tests for updated User XContent requirements
Signed-off-by: Daniel Widdis <widdis@gmail.com>
1 parent 1ef7546 commit bdb5e84

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ dependencies {
264264
// Some other plugin dependencies that don't use version catalog conflict here
265265
force("com.google.guava:guava:${versions.guava}")
266266
force("org.slf4j:slf4j-api:${versions.slf4j}")
267-
force("com.google.errorprone:error_prone_annotations:${versions.error_prone_annotations}")
268267

269268
if (System.getenv('REMOTE_METADATA_SDK_IMPL') == 'ddb-client') {
270269
// OpenSearch Java client brings in different versions of the below dependencies.

src/test/java/org/opensearch/flowframework/util/ParseUtilsTests.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,12 @@ public void testAddUserRoleFilterWithNullUser() {
122122
public void testAddUserRoleFilterWithNullUserBackendRole() {
123123
SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder();
124124
ParseUtils.addUserBackendRolesFilter(
125-
new User(randomAlphaOfLength(5), null, ImmutableList.of(randomAlphaOfLength(5)), ImmutableList.of(randomAlphaOfLength(5))),
125+
new User(
126+
randomAlphaOfLength(5),
127+
null,
128+
ImmutableList.of(randomAlphaOfLength(5)),
129+
ImmutableList.of(String.join("=", randomAlphaOfLength(5), randomAlphaOfLength(5)))
130+
),
126131
searchSourceBuilder
127132
);
128133
assertEquals(
@@ -140,7 +145,7 @@ public void testAddUserRoleFilterWithEmptyUserBackendRole() {
140145
randomAlphaOfLength(5),
141146
ImmutableList.of(),
142147
ImmutableList.of(randomAlphaOfLength(5)),
143-
ImmutableList.of(randomAlphaOfLength(5))
148+
ImmutableList.of(String.join("=", randomAlphaOfLength(5), randomAlphaOfLength(5)))
144149
),
145150
searchSourceBuilder
146151
);
@@ -161,7 +166,7 @@ public void testAddUserRoleFilterWithUserBackendRole() {
161166
randomAlphaOfLength(5),
162167
ImmutableList.of(backendRole1, backendRole2),
163168
ImmutableList.of(randomAlphaOfLength(5)),
164-
ImmutableList.of(randomAlphaOfLength(5))
169+
ImmutableList.of(String.join("=", randomAlphaOfLength(5), randomAlphaOfLength(5)))
165170
),
166171
searchSourceBuilder
167172
);
@@ -420,7 +425,7 @@ public void testIsAdmin() {
420425
randomAlphaOfLength(5),
421426
ImmutableList.of(),
422427
ImmutableList.of("all_access"),
423-
ImmutableList.of(randomAlphaOfLength(5))
428+
ImmutableList.of(String.join("=", randomAlphaOfLength(5), randomAlphaOfLength(5)))
424429
);
425430
assertTrue(isAdmin(user1));
426431
}
@@ -431,7 +436,7 @@ public void testIsAdminBackendRoleIsAllAccess() {
431436
randomAlphaOfLength(5),
432437
ImmutableList.of(backendRole1),
433438
ImmutableList.of(randomAlphaOfLength(5)),
434-
ImmutableList.of(randomAlphaOfLength(5))
439+
ImmutableList.of(String.join("=", randomAlphaOfLength(5), randomAlphaOfLength(5)))
435440
);
436441
assertFalse(isAdmin(user1));
437442
}

0 commit comments

Comments
 (0)