Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] added _doc_count field to summary documents #829

Closed
petardz opened this issue Jul 25, 2022 · 3 comments · Fixed by #839 or #870
Closed

[FEATURE] added _doc_count field to summary documents #829

petardz opened this issue Jul 25, 2022 · 3 comments · Fixed by #839 or #870
Assignees
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge index-management v2.2.0
Milestone

Comments

@petardz
Copy link

petardz commented Jul 25, 2022

Is your feature request related to a problem?

We need this new field documented for v2.2.0 PR

Do you have any additional context?

Description would be something like this:

Documents that store pre-aggregated data will have _doc_countfield representing the number of documents aggregated in a single summary field. When computingdoc_countfield, value of_doc_countwill be used, if available, instead of1.
This could be added to bucket-agg.md in "doc_count" paragraph.

@petardz petardz added enhancement New feature or request untriaged labels Jul 25, 2022
@Naarcha-AWS Naarcha-AWS added index-management and removed untriaged enhancement New feature or request labels Jul 28, 2022
@Naarcha-AWS Naarcha-AWS added this to the v2.2 milestone Jul 28, 2022
@Naarcha-AWS Naarcha-AWS added the 1 - Backlog Issue: The issue is unassigned or assigned but not started label Jul 28, 2022
@cwillum
Copy link
Contributor

cwillum commented Jul 28, 2022

@petardz To clarify, from your "additional context" description: "documents that store pre-aggregated data" are those calculated and shown in a response. Yes? Could I see an example of this?
And, this field appears as _doc_count and should not to be confused with doc_count Right?

@cwillum
Copy link
Contributor

cwillum commented Jul 28, 2022

@petardz Actually, it might be more helpful to have a realistic example of a request that would naturally include this field for documents that store pre-aggregated data. Can you think of a document that that would include pre-aggregated data?

@petardz
Copy link
Author

petardz commented Jul 29, 2022

@cwillum
[removed external reference]

In ISM plugin, rollup jobs store these documents with pre-aggregated data in rollup indices. We need small PR to include this _doc_count field in them and once that's done we will have correct doc_count calculation when querying rollup indices.

@Naarcha-AWS Naarcha-AWS assigned kolchfa-aws and cwillum and unassigned cwillum Aug 1, 2022
@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress Needs SME Waiting on input from subject matter expert and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started Needs SME Waiting on input from subject matter expert labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment