Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update delete API in ML #7838

Open
1 of 4 tasks
ylwu-amzn opened this issue Jul 25, 2024 · 2 comments
Open
1 of 4 tasks

[DOC] Update delete API in ML #7838

ylwu-amzn opened this issue Jul 25, 2024 · 2 comments
Assignees
Labels
1 - Backlog - DEV Developer assigned to issue is responsible for creating PR.

Comments

@ylwu-amzn
Copy link
Contributor

ylwu-amzn commented Jul 25, 2024

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request.

Add exception details for ML APIs: delete API will throw not found exception (404) if model/agent not exist.

User (like FlowFramework team) read our API document and they don't see exception details of delete APIs (delete connector/model group/model/agent etc). So they thought the delete API will not throw error if resource not found.
But actually we are following the same style of OpenSearch core, when user delete a non-existing document, 404 error will return

*Version: List the OpenSearch version to which this issue applies, e.g. 2.14, 2.12--2.14, or all.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@hdhalter
Copy link
Contributor

@ylwu-amzn , is this related to 2.16?

@hdhalter hdhalter added v2.16.0 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed untriaged labels Jul 26, 2024
@hdhalter hdhalter changed the title [DOC] [DOC] Update delete API in ML Jul 26, 2024
@hdhalter hdhalter removed the v2.16.0 label Jul 26, 2024
@ylwu-amzn
Copy link
Contributor Author

This is not for 2.16 release. @b4sjoo Sicheng, can you help on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Backlog - DEV Developer assigned to issue is responsible for creating PR.
Projects
None yet
Development

No branches or pull requests

2 participants