Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternate CloudWatch configurations for monitoring Data Prepper #4465

Open
dlvenable opened this issue Apr 25, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

Data Prepper supports CloudWatch as a metric destination for its own metrics. The data-prepper-core project includes a cloudwatch.properties file.

It is good that Data Prepper is pre-configured for CloudWatch so that no additional configuration is needed.

However, the current approach provides some difficulties:

  • It is difficult to override these configurations
  • When creating a custom Data Prepper distribution, the file in this jar may conflict with other similar files that teams provide.

Describe the solution you'd like

Move the cloudwatch.properties file out of data-prepper-core.jar. Instead, include it in the config directory of Data Prepper at config/cloudwatch.properties. With this, users can change this file and get their own custom configurations.

Describe alternatives you've considered (Optional)

There may still be some value in including the cloudwatch.properties file in the jars. If so, we may wish to move it into data-prepper-main.jar since that jar is more opinionated on how Data Prepper is run.

Additional context

See #4464 for another file that is in data-prepper-core.jar and causing difficulty for custom distributions.

@dlvenable dlvenable added untriaged enhancement New feature or request and removed untriaged labels Apr 25, 2024
@dlvenable dlvenable self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant