Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]+[FEATURE] Query Workbench should have an implementation to support cross cluster redirection #403

Open
RyanL1997 opened this issue Oct 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@RyanL1997
Copy link
Contributor

RyanL1997 commented Oct 16, 2024

Problem to solve

Under the MDS environment, when the redirection from datasource management to query workbench happens, there is a cluster selection mismatch.

BackGround

With the support of MDS in 2.14+, query workbench itself has the ability to consume the remote cluster api calls for query the remote content, since it has a global data picker for cluster selection. However, when other plugins, such as, data source management, is trying to redirect into the query workbench, it doesn't has the mechanism to point the query to a specific cluster.

The above issue gets surfaced up, since the original global datasource picker in data source management that introduced in PR:

was removed in PR:

According to this, when redirection to query workbench happens in data source management, query workbench will always treat as the targeting cluster as the the current global value of the current cluster, which in the above case, the global value is not being setup, so it will always select the default cluster.

Here is a video of how to reproduce the issue:

  1. Enable MDS and connect to a remote cluster.
  2. Get a flint setup domain on local cluster
  3. Go to Datasource management page and select the flint datasource in the "direct query connections" tab for the local cluster
  4. Click into the detailed connection page, and click on the "Create Acceleration" card/button, so that it will pop up the Flint acceleration creation flow as a flyout.
  5. Try to filling the required field, for a creation of Skipping/MV/CV/
  6. Select "Preview SQL Definition" and click on "Edit in query workbench"
  7. When the redirection happens, even the query that generated in datasource management for local cluster's flint datasource is pasted in query workbench,. However, the cluster picker in query workbench shows the user is querying in the remote cluster, since that is the default cluster.
Screen.Recording.2024-10-15.at.6.18.49.PM.mov

How to resolve this issue

  • Query workbench should has an implementation to consume the cluster selection for redirection. (e.g. cluster id) - so that, when the redirection in data source management happens, it knows which remote cluster is this redirection referring to.
  • Datasource management should also adapt the above change by passing the cluster identifier to query workbench.
@RyanL1997 RyanL1997 added enhancement New feature or request untriaged labels Oct 16, 2024
@RyanL1997 RyanL1997 changed the title [Bug]+[FEATURE] Query Workbench should have a mechanism to support cross cluster redirection [Bug]+[FEATURE] Query Workbench should have an implementation to support cross cluster redirection Oct 16, 2024
@dblock dblock removed the untriaged label Nov 4, 2024
@dblock
Copy link
Member

dblock commented Nov 4, 2024

[Catch All Triage - 1, 2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants