Move notification plugin into management section on left navigation menu #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 51 51
Lines 1479 1479
Branches 352 352
=======================================
Hits 1280 1280
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
changed the title
|
changes in OpenSearch-dashboard opensearch-project/OpenSearch-Dashboards#4287 |
Hailong-am
requested review from
xluo-aws,
gaobinlong,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90 and
praveensameneni
as code owners
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
added
backport 2.x
enhancement
Signed-off-by: Hailong Cui <ihailong@amazon.com>
xluo-aws
approved these changes
Jul 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
…enu (#46) * move notification into management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> * wording update Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit f26c1ca)
Hailong-am
added a commit
that referenced
this pull request
Jul 10, 2023
…enu (#46) (#67) * move notification into management section Signed-off-by: Hailong Cui <ihailong@amazon.com> * Fix eslint Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove plugins pages for management overview registration Signed-off-by: Hailong Cui <ihailong@amazon.com> * wording update Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit f26c1ca) Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move notification from plugins section into Management section and register which pages does the plugin have to show in management overview page
Issues Resolved
#48
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.