Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure common-utils can be a drop-in replacement for job-scheduler working in ODFE 1.13 and ES 7.10.x for v1.0.0 #19

Closed
3 of 9 tasks
dblock opened this issue May 18, 2021 · 3 comments

Comments

@dblock
Copy link
Member

dblock commented May 18, 2021

Coming from opensearch-plugins#12, enable upgrade to OpenSearch, while supporting backward compatibility.

  • Rename Namespaces (e.g. com.amazon.opendistroforelasticsearch to org.opensearch)
  • Rename Classes, Methods, Variables
  • Rename Remaining Identifiers (e.g. Opendistro to OpenSearch).
  • Rename, and Backwards Compatibility for Rest APIs
  • Rename, and Backwards Compatibility for Settings
  • Rename, and Backwards Compatibility for Indices
  • Run in a backwards compatible way on top of OpenSearch 1.0 that has joined an ES 7.10.x cluster
  • Run in a backwards compatible way on top of OpenSearch 1.0 that has joined an ODFE 1.13.x cluster
  • Drop in replacement for the Opendistro version 1.13 of the plugin
@dblock dblock added enhancement New feature or request backwards-compatibility and removed enhancement New feature or request labels May 18, 2021
@dblock dblock changed the title Ensure job-scheduler can be a drop-in replacement for job-scheduler working in ODFE 1.13 and ES 7.10.x for v1.0.0 Ensure common-utils can be a drop-in replacement for job-scheduler working in ODFE 1.13 and ES 7.10.x for v1.0.0 May 18, 2021
@VachaShah
Copy link
Contributor

VachaShah commented May 20, 2021

Renaming of the namespaces, classes, variables, methods and identifiers is done to reflect OpenSearch. There are some settings and APIs being used from security which need to be updated once security-plugin comes in with the update. I have opened an issue for this: #22.

For the above checklist, the remaining part is the update in CI.yml to required OpenSearch version.

Note: Renaming for Rest APIs, Indices and Settings is not applicable for this repo.

@dblock
Copy link
Member Author

dblock commented Jun 22, 2021

@VachaShah What else needs to be done for this, or can it be closed?

@dblock dblock added the v1.0.0 label Jun 22, 2021
@VachaShah
Copy link
Contributor

@dblock Looks like all the required items are complete for this, it can be closed.

@dblock dblock closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants