Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add more tests coverage for AD task runner and task manager #493

Open
Zhangxunmt opened this issue Apr 5, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Zhangxunmt
Copy link
Contributor

Zhangxunmt commented Apr 5, 2022

The jacocoExclusions list includes two important classes in the AD tasks layer. https://github.com/opensearch-project/anomaly-detection/blob/main/build.gradle#L547. They lack tests coverage which may cause bugs. We should add more tests to meet the bar for the following classes.

    // TODO: fix unstable code coverage caused by null NodeClient issue
    // https://github.com/opensearch-project/anomaly-detection/issues/241
    'org.opensearch.ad.task.ADBatchTaskRunner',
    'org.opensearch.ad.task.ADTaskManager',

    'org.opensearch.ad.AnomalyDetectorRunner'
    // TODO: unified flow caused coverage drop
    'org.opensearch.ad.transport.DeleteAnomalyResultsTransportAction',
    //TODO: custom result index caused coverage drop
    'org.opensearch.ad.transport.handler.AnomalyResultBulkIndexHandler'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant