Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts should be visible to users who have access to the tenant #119

Closed
aimtsou opened this issue Jun 25, 2021 · 5 comments
Closed

Alerts should be visible to users who have access to the tenant #119

aimtsou opened this issue Jun 25, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@aimtsou
Copy link

aimtsou commented Jun 25, 2021

Is your feature request related to a problem? Please describe.
Since we have the multi-tenancy it will be important for each user in the alerting plugin(dashboards, monitors, destinations) to be able to define the options and has access to rules for the tenants that he belongs to. Consequently:

  1. The alerting dashboard has only your own alerts and you do not search for them
  2. Your alerts page contains your own alerts and nobody from another tenant can access and/or modify them
  3. Destinations also are belonging to the user/s of the tenant

Describe the solution you'd like
Alerting package should belong only to the users of each tenant. If user1 has access to tenant1 then he sees the alerts configured for tenant1. If user1 has access to tenant1 and to tenant2, according to which tenant he has chosen, then considering his rights he is able to see and modify the alerts for this specific tenant.

Describe alternatives you've considered
No alternatives at the moment but we consider this an important enhancement

@aimtsou aimtsou added the enhancement New feature or request label Jun 25, 2021
@aimtsou
Copy link
Author

aimtsou commented Sep 30, 2021

Another addition to this, when choosing your own index then the list displaying the indices should be limited to your tenant only besides you are an admin as described here #139

Generally an admin should be able to see everything.

@skkosuri-amzn
Copy link
Contributor

@aimtsou Currently, OpenSearch-Dashboard-tenancy is for OpenSearch-Dashboard objects like dashboard, saved queries and few more. Alerting objects are not OpenSearch-Dashboard objects, you can group users using permissions/roles/backend roles while using Alerting. There is no plan to extend OpenSearch-Dashboard-tenancy to OpenSearch constructs like Alerting.

@aimtsou
Copy link
Author

aimtsou commented Oct 1, 2021

But permissions in Alerting allow read/write to users, they do not allow index-based usage.
Putting it differently, you cannot offer tenancy in dashboard / visualizations but all the rest of the elements to be open to everybody as they can be combined with the information from dashboards.

@JujuElk
Copy link

JujuElk commented Nov 17, 2022

Hi @brijos and @skkosuri-amzn, this enhancement of Alerting plugin could be great for us as well. Do you have any update concerning the backlog of this feature ?

@lezzago lezzago assigned lezzago and unassigned skkosuri-amzn Dec 20, 2022
@lezzago
Copy link
Member

lezzago commented Dec 20, 2022

@JujuElk, like @skkosuri-amzn had mentioned, OpenSearch-Dashboard-tenancy is for OpenSearch-Dashboard objects like dashboard, saved queries and few more, but alerting objects are not OpenSearch-Dashboard objects and are OpenSearch objects.

For this enhancement to be supported, the security plugin needs to connect with OpenSearch Dashboard's tenants to allow OpenSearch objects have different access control on OpenSearch-Dashboards using tenants.
Feel free to submit a feature request on the security plugin here to support a mechanism to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants