-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable merge policy and option to choose between LogByteSize and Tiered MergePolicy #9992
Configurable merge policy and option to choose between LogByteSize and Tiered MergePolicy #9992
Conversation
Compatibility status:Checks if related components are compatible with change 7caa621 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9992 +/- ##
============================================
- Coverage 71.18% 71.12% -0.07%
+ Complexity 58241 58220 -21
============================================
Files 4830 4831 +1
Lines 274592 274598 +6
Branches 40020 40008 -12
============================================
- Hits 195469 195296 -173
- Misses 62701 62959 +258
+ Partials 16422 16343 -79
|
bd49090
to
3fa195a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
589332c
to
7caa621
Compare
@msfroh good to go? |
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9992-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fa66bebf88d6fc69765d5ecb26930ece94477024
# Push it to GitHub
git push --set-upstream origin backport/backport-9992-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit fa66beb)
2.x backport PR - #10312 |
@rishabhmaurya please create a documentation issue / section for this new setting(s) here , github.com/Opensearch-project/documentation-website/, we'll need it for 2.11 release, thank you. |
@reta I have the issue opened for documentation opensearch-project/documentation-website#5119 thank you. |
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit fa66beb)
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit fa66beb)
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
* Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit fa66beb)
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…roject#9992) * Configurable merge policy for index * additional setting to configure merge policy for timestamp based index * introduction of logbytesize merge policy as an option Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * remove the trace log not required anymore Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Refactor the merge policy extraction logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Rename constant DEFAULT to DEFAULT_POLICY Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Simplify merge policy extraction and selection logic Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * missing javadoc error Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Renaming log byte size policy setting with mb Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * Move validation exception to enum from setting defn Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> * rename time_index to time_series_index Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
#9241
currently due to lack of appropriate benchmark, we don't have a promising numbers to show the benefits. Thus keeping tiered merge policy as default until we have enough confidence on the change to make it as a default for data streams.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.