Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CheckCompatibility] Prevent interleaving of log output #9280

Merged
merged 2 commits into from
Aug 15, 2023
Merged

[CheckCompatibility] Prevent interleaving of log output #9280

merged 2 commits into from
Aug 15, 2023

Conversation

peternied
Copy link
Member

@peternied peternied commented Aug 11, 2023 •
edited
Loading

Description

Prevent interleaving of log output and add more detail logging

Example output at standard log level 
> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/sql.git with ref: main
Checking compatibility for: https://github.com/opensearch-project/security.git with ref: main
Finished compatibility check for https://github.com/opensearch-project/security.git
Error output for https://github.com/opensearch-project/security.git build:

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Finished compatibility check for https://github.com/opensearch-project/sql.git
Error output for https://github.com/opensearch-project/sql.git build:

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
/tmp/groovy-generated-tmpdir-6721287947875417197/opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/core/ExpressionScript.java:64: warning: [removal] AccessController in java.security has been deprecated and marked for removal
    this.fields = AccessController.doPrivileged((PrivilegedAction<Set<ReferenceExpression>>) () ->
                  ^
...

Updated status report comment with markdown:

Compatibility status:

Checks if related components are compatible with change fe1e87e

Incompatible components

Skipped components

Compatible components

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied
[CheckCompatibility] Prevent interleaving of log output
822c355 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied mentioned this pull request Aug 11, 2023
Closed
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 24m 25s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Yury-Fridlyand
Copy link

Is it possible to make output more readable (and with MD)? For example:

## Compatible
* one
* two
* three

## Incompatible ❗ ❗ 
* ...

This message could also include tagging the corresponding teams.

gaiksaya
gaiksaya reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM.

buildSrc/src/main/groovy/org/opensearch/gradle/CheckCompatibilityTask.groovy Show resolved Hide resolved
@peternied
Switch comment to markdown format
8518854 
Signed-off-by: Peter Nied <petern@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git]
Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 25m 37s

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 26m 50s

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #9280 (8518854) into main (3ddff4c) will increase coverage by 0.12%.
Report is 12 commits behind head on main.
The diff coverage is 67.64%.

@@             Coverage Diff              @@
##               main    #9280      +/-   ##
============================================
+ Coverage     71.11%   71.23%   +0.12%     
- Complexity    57351    57517     +166     
============================================
  Files          4771     4774       +3     
  Lines        270587   270664      +77     
  Branches      39564    39570       +6     
============================================
+ Hits         192420   192813     +393     
+ Misses        61950    61708     -242     
+ Partials      16217    16143      -74
Files Changed Coverage Δ
...rg/opensearch/gradle/CheckCompatibilityTask.groovy 0.00% <0.00%> (ø)
.../opensearch/telemetry/tracing/noop/NoopTracer.java 66.66% <0.00%> (-13.34%) ⬇️
...nsearch/script/mustache/SearchTemplateRequest.java 78.18% <0.00%> (-2.20%) ⬇️
...opensearch/identity/shiro/ShiroIdentityPlugin.java 88.88% <ø> (ø)
...g/opensearch/extensions/NoopExtensionsManager.java 42.85% <ø> (ø)
...g/opensearch/identity/noop/NoopIdentityPlugin.java 100.00% <ø> (ø)
server/src/main/java/org/opensearch/node/Node.java 86.10% <ø> (ø)
...rch/extensions/rest/RestSendToExtensionAction.java 42.14% <20.00%> (-0.36%) ⬇️
...ensearch/extensions/rest/ExtensionRestRequest.java 71.59% <33.33%> (-1.67%) ⬇️
...g/opensearch/identity/shiro/ShiroTokenManager.java 81.81% <50.00%> (+16.70%) ⬆️
... and 12 more

... and 476 files with indirect coverage changes

@peternied
Copy link
Member Author

@gaiksaya - would you be willing to approve?
@ticheng-aws @dreamer-89 @sachinpkale - I've selected you all at random, could you please help me get this reviewed and merged?

@ticheng-aws
Copy link
Contributor

LGTM. Thanks, @peternied.

tlfeng
tlfeng approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tlfeng tlfeng added the backport 2.x Backport to 2.x branch label Aug 15, 2023
@tlfeng tlfeng merged commit 23fd9a5 into opensearch-project:main Aug 15, 2023
16 of 18 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 15, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2023
@github-actions
[CheckCompatibility] Prevent interleaving of log output (#9280)
ee2f0a3 
Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 23fd9a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peternied peternied deleted the check-compat branch August 15, 2023 18:03
gaiksaya pushed a commit that referenced this pull request Aug 15, 2023
@opensearch-trigger-bot @github-actions
[CheckCompatibility] Prevent interleaving of log output (#9280) (#9357)
b3f8faf 
(cherry picked from commit 23fd9a5)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
@peternied @kkmr
[CheckCompatibility] Prevent interleaving of log output (opensearch-p…
b84b233 
…roject#9280)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@peternied @kaushalmahi12
[CheckCompatibility] Prevent interleaving of log output (opensearch-p…
eec8758 
…roject#9280)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@peternied @brusic
[CheckCompatibility] Prevent interleaving of log output (opensearch-p…
9616fdd 
…roject#9280)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@peternied @shiv0408
[CheckCompatibility] Prevent interleaving of log output (opensearch-p…
a2c0b9c 
…roject#9280)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ticheng-aws ticheng-aws ticheng-aws approved these changes

@gaiksaya gaiksaya gaiksaya approved these changes

@tlfeng tlfeng tlfeng approved these changes

@MitchellGale MitchellGale MitchellGale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peternied @Yury-Fridlyand @ticheng-aws @gaiksaya @tlfeng @MitchellGale