Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jdk.incubator.vector module support for JDK 20+ #8601

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 10, 2023

Adds support for the incubating jdk vector package (PANAMA) when using jdk 20+ runtime.

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added enhancement Enhancement or improvement to existing feature or request non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.10.0 labels Jul 10, 2023
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@reta reta merged commit 62b66e5 into opensearch-project:main Jul 10, 2023
@reta
Copy link
Collaborator

reta commented Jul 10, 2023

@nknize the 2.x (or 2.10.0) is still on JDK-17, do you think we need to backport?

@nknize
Copy link
Collaborator Author

nknize commented Jul 10, 2023

@nknize the 2.x (or 2.10.0) is still on JDK-17, do you think we need to backport?

Yes. Users can still specify jdk 20 for the java runtime to take advantage of Lucene's SIMD optimizations.

=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.2.1
  OS Info               : Linux 5.17.0-1033-oem (amd64)
  JDK Version           : 20 (Oracle JDK)
  JAVA_HOME             : /usr/lib/jvm/jdk-20
  Random Testing Seed   : 440C11C1AD7A24A6
  In FIPS 140 mode      : false
=======================================
...

[2023-07-10T15:41:24,729][INFO ][o.o.n.Node               ] [runTask-0] JVM arguments [-Xshare:auto, -Dopensearch.networkaddress.cache.ttl=60, -Dopensearch.networkaddress.cache.negative.ttl=10, -XX:+AlwaysPreTouch, -Xss1m, 
-Djava.awt.headless=true, -Dfile.encoding=UTF-8, -Djna.nosys=true, -XX:-OmitStackTraceInFastThrow, -XX:+ShowCodeDetailsInExceptionMessages, -Dio.netty.noUnsafe=true, -Dio.netty.noKeySetOptimization=true, 
-Dio.netty.recycler.maxCapacityPerThread=0, -Dio.netty.allocator.numDirectArenas=0, -Dlog4j.shutdownHookEnabled=false, -Dlog4j2.disable.jmx=true, -Djava.security.manager=allow, -Djava.locale.providers=SPI,COMPAT, 
-Xms1g, -Xmx1g, -XX:+UseG1GC, -XX:G1ReservePercent=25, -XX:InitiatingHeapOccupancyPercent=30, -Djava.io.tmpdir=/opt/dev/opensearch-project/opensearch/.worktrees/enhance/jdk-vector-module/build/testclusters/runTask-0/tmp, 
-XX:+HeapDumpOnOutOfMemoryError, -XX:HeapDumpPath=logs, -XX:ErrorFile=logs/hs_err_pid%p.log, -Xlog:gc*,gc+age=trace,safepoint:file=logs/gc.log:utctime,pid,tags:filecount=32,filesize=64m, -Djava.security.manager=allow, 
--add-modules=jdk.incubator.vector, -Xms512m, -Xmx512m, -ea, -esa, -XX:TieredStopAtLevel=1, -XX:ReservedCodeCacheSize=64m, -XX:MaxDirectMemorySize=268435456, 
...

vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added the backport 2.x Backport to 2.x branch label Jul 12, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8601-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62b66e56b9eddda1313a71ca90f2e95f45cdec5d
# Push it to GitHub
git push --set-upstream origin backport/backport-8601-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8601-to-2.x.

dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
heemin32 pushed a commit to heemin32/OpenSearch that referenced this pull request Aug 22, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 62b66e5)
heemin32 pushed a commit to heemin32/OpenSearch that referenced this pull request Aug 22, 2023
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 62b66e5)
Signed-off-by: Heemin Kim <heemin@amazon.com>
reta pushed a commit that referenced this pull request Aug 23, 2023
* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.



* update changelog and fix typo



---------


(cherry picked from commit 62b66e5)

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Heemin Kim <heemin@amazon.com>
Co-authored-by: Nick Knize <nknize@apache.org>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ct#8601)

* add jdk.incubator.vector module support for JDK 20+

Adds support for the incubating jdk vector package (PANAMA) when using
jdk 20+ runtime.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

* update changelog and fix typo

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants