-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task cancellation monitoring service #7642
Task cancellation monitoring service #7642
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7642 +/- ##
============================================
+ Coverage 70.84% 71.07% +0.23%
- Complexity 56464 56651 +187
============================================
Files 4702 4706 +4
Lines 266973 267135 +162
Branches 39157 39167 +10
============================================
+ Hits 189131 189862 +731
+ Misses 61897 61283 -614
- Partials 15945 15990 +45
|
server/src/main/java/org/opensearch/tasks/TaskCancellationMonitoringService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Lets ensure we open an issue for all things needing a followup. |
@Bukhtawar Sure. I have created desired issues for the things we need to track or follow up on. |
* Task cancellation monitoring service Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
* Task cancellation monitoring service (#7642) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
…ct#8046) * Task cancellation monitoring service (opensearch-project#7642) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
* Task cancellation monitoring service Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Task cancellation monitoring service Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This has dependency on changes(Task API) raised as part of this PR - Adding task cancellation timestamp in task API #7445. Once that is pushed, I will rebase.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#6953
Testing
Spun up a opensearch cluster. Introduced a deliberate delay in search request, then cancelled it. Verified that node stats and task API are being populated correctly.
Task API related testing here - #7445
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.