Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Adding cross version support for registering Transport Actions #7403

Merged

Conversation

saratvemulapalli
Copy link
Member

Description

Adding cross version support for registering transport actions API for extensions via protobuf.

Related Issues

Part of #7402

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@saratvemulapalli
Copy link
Member Author

@kotwanikunal updated the dev guide. Hopefully this helps, if there's anything missing let me know.

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #7403 (7aa7fbf) into main (3687d01) will decrease coverage by 0.09%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7403      +/-   ##
============================================
- Coverage     70.63%   70.55%   -0.09%     
+ Complexity    59554    59507      -47     
============================================
  Files          4875     4875              
  Lines        285744   285743       -1     
  Branches      41160    41161       +1     
============================================
- Hits         201825   201594     -231     
- Misses        67327    67540     +213     
- Partials      16592    16609      +17     
Impacted Files Coverage Δ
...nsions/action/RegisterTransportActionsRequest.java 78.94% <80.00%> (-6.06%) ⬇️

... and 496 files with indirect coverage changes

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! With small comments

CHANGELOG.md Show resolved Hide resolved
DEVELOPER_GUIDE.md Show resolved Hide resolved
@saratvemulapalli saratvemulapalli added backport PRs or issues specific to backporting features or enhancments backport 2.x Backport to 2.x branch and removed backport PRs or issues specific to backporting features or enhancments labels May 3, 2023
@saratvemulapalli saratvemulapalli merged commit eacfb70 into opensearch-project:main May 3, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7403-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eacfb70f6492c1b47c6047444066d1ecdf7a0dcd
# Push it to GitHub
git push --set-upstream origin backport/backport-7403-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7403-to-2.x.

@saratvemulapalli saratvemulapalli deleted the transport-actions branch May 3, 2023 23:45
saratvemulapalli added a commit to saratvemulapalli/OpenSearch that referenced this pull request May 3, 2023
…ctions (opensearch-project#7403)

* Adding cross version support for RegisterTransportActions for extensions

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
saratvemulapalli added a commit that referenced this pull request May 4, 2023
…ctions (#7403) (#7412)

* Adding cross version support for RegisterTransportActions for extensions

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ctions (opensearch-project#7403)

* Adding cross version support for RegisterTransportActions for extensions

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants