OpenJDK Update (April 2023 Patch releases)

[reta]

Description

OpenJDK Update (April 2023 Patch releases): OpenJDK 20.0.1 / 17.0.7+7 / 11.0.19+7

Related Issues

Resolves #[7252], depends on opensearch-project/opensearch-build#3457

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

Keeping a draft for now, Linux/ppc64le is not yet released

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14701/
• CommitID: e277cc5
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14702/
• CommitID: 339d3f4
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14739/
• CommitID: 65570e6
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/14952/
• CommitID: 24e2cb0
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16028/
• CommitID: 33e3434
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16030/
• CommitID: 1b1c60b
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[peterzhuamazon]

Still waiting: https://adoptium.net/temurin/releases/?version=20

[reta]

@dblock @peterzhuamazon not so good news [1], the Linux/ppc64le, Linux/s390x, Linux/arm32 and AIX/ppc64 won't be released for 20.0.1+9, I will try to preserve the older one for those while moving everything else to JDK-20.0.1+9

[1] adoptium/temurin-build#3371

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16450/
• CommitID: 0cd70ac
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16455/
• CommitID: 0cd70ac
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16480/
• CommitID: b63d8d7
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/16489/
• CommitID: 6e4e20d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

• URL: https://build.ci.opensearch.org/job/gradle-check/16494/
• CommitID: 6e4e20d
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #7344 (43a1831) into main (4df347c) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##               main    #7344      +/-   ##
============================================
- Coverage     70.81%   70.78%   -0.04%     
+ Complexity    56242    56238       -4     
============================================
  Files          4687     4687              
  Lines        266231   266241      +10     
  Branches      39095    39096       +1     
============================================
- Hits         188540   188448      -92     
- Misses        61685    61816     +131     
+ Partials      16006    15977      -29     

Impacted Files	Coverage Δ
.../java/org/opensearch/gradle/JdkDownloadPlugin.java	37.50% <0.00%> (+1.23%)	⬆️
...a/org/opensearch/gradle/test/DistroTestPlugin.java	0.00% <ø> (ø)
.../opensearch/common/util/concurrent/BaseFuture.java	62.71% <ø> (ø)
.../java/org/opensearch/gradle/VersionProperties.java	53.06% <28.57%> (-8.05%)	⬇️

... and 478 files with indirect coverage changes

[reta]

@dblock mind checking this one? I would like to publish new Apache Lucene snaphots after with:

• Integrate the Incubating Panama Vector API  apache/lucene#12311 (backported to 9.7)

[peterzhuamazon]

So @reta how do we move forward at this point?
Switch back to nightly builds of 20?
Thanks.

[reta]

Switch back to nightly builds of 20?

@peterzhuamazon yes, when it is merged, we could use JDK-20 in 3.0.0 manifest

[reta]

@dblock @andrross mind taking a look? thank you

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testFlushAfterRelocation

• URL: https://build.ci.opensearch.org/job/gradle-check/16659/
• CommitID: 43a1831
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dhrubo-os]

Just curious to know why are we updating to Java 20, when most updated gradle version 8.1.1 doesn't have support for it yet?

https://docs.gradle.org/current/userguide/compatibility.html

[reta]

Just curious to know why are we updating to Java 20, when most updated gradle version 8.1.1 doesn't have support for it yet?

@dhrubo-os 8.1.x supports JDK-20, there are issues with Kotlin DSL (afaik, [1]) which we are not affecting us anyhow

[1] gradle/gradle#23488