Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TopNSearchTasksLogger settings to Cluster Settings (#6716) #7242

Merged

Conversation

PritLadani
Copy link
Contributor

Description

We introduced Task Resource Consumer to log task resource information at a specified interval as a part of #2293. However, newly introduced dynamic settings cluster.task.consumers.top_n.size and cluster.task.consumers.top_n.frequency are not registered under ClusterSettings.BUILT_IN_CLUSTER_SETTINGS and hence not recognised when trying to change the value. We need to register them in ClusterSettings.BUILT_IN_CLUSTER_SETTINGS to make them dynamic. Making this change to fix the issue.

Issues Resolved

#6708

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…oject#6716)

Signed-off-by: PritLadani <pritkladani@gmail.com>
(cherry picked from commit 9f6c067)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollWithOngoingSegmentReplication
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

@codecov-commenter
Copy link

Codecov Report

Merging #7242 (56f090c) into 2.7 (df0d8e2) will decrease coverage by 0.17%.
The diff coverage is 89.47%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.7    #7242      +/-   ##
============================================
- Coverage     70.36%   70.20%   -0.17%     
+ Complexity    59740    59594     -146     
============================================
  Files          4847     4847              
  Lines        287115   287127      +12     
  Branches      41716    41716              
============================================
- Hits         202029   201576     -453     
- Misses        68252    68671     +419     
- Partials      16834    16880      +46     
Impacted Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...ensearch/tasks/consumer/TopNSearchTasksLogger.java 91.89% <84.61%> (-4.66%) ⬇️
server/src/main/java/org/opensearch/node/Node.java 85.13% <100.00%> (+0.04%) ⬆️
...search/backpressure/SearchBackpressureService.java 87.73% <100.00%> (ø)
...rc/main/java/org/opensearch/tasks/TaskManager.java 65.74% <100.00%> (+0.21%) ⬆️

... and 508 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gbbafna gbbafna merged commit c00e0f7 into opensearch-project:2.7 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants