-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI] Update CONTRIBUTING.md: add entry about good first issue, first PR #7027
[CCI] Update CONTRIBUTING.md: add entry about good first issue, first PR #7027
Conversation
Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7027 +/- ##
============================================
+ Coverage 70.66% 70.77% +0.10%
- Complexity 59231 59302 +71
============================================
Files 4812 4813 +1
Lines 283761 283762 +1
Branches 40917 40917
============================================
+ Hits 200519 200821 +302
+ Misses 66784 66485 -299
+ Partials 16458 16456 -2
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel pretty strongly that this belongs in https://github.com/opensearch-project/.github/blob/main/ONBOARDING.md, and that it's not our job here to teach folks the basics of git. Can we link a section to ONBOARDING about git below the GitHub one, and link a good external tutorial instead?
@dblock I'm sorry, but if so, can this git guide be added to the forum and somehow leave a link? |
You should just post it somewhere and I am a maybe on a link to a forum because there's a million existing tutorials for git and because yours only works for some people (for example Ctrl + Shift + G isn't something that works on my mac). This way I point people to https://docs.github.com/en/get-started/quickstart or the million other tutorials for git that will be there for a long time. Maybe other maintainers feel otherwise. |
This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Apologies. This PR was auto closed without reaching a resolution from the maintainers. |
Compatibility status:Checks if related components are compatible with change 560358d Incompatible componentsSkipped componentsCompatible components |
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the part that references ONBOARDING, but I don't love the rest. This doc should have mostly OpenSearch core-specific things, and this is one massive repo to start contributing in "small stuff".
I'd remove all the parts about learning git, and making a first PR into any repo from here. I'd want to direct users to ONBOARDING, which itself should be directing users to https://docs.github.com/en/get-started/quickstart/github-flow.
I agree with @dblock assessment, being that this pull request has stalled for a considerable amount of time and the issue associated [1] with it was resolved as not planned, I'm closing out this pull request. |
Description
CONTRIBUTING.md update:
The way I see it, this PR should help newbies who don't know how to work with git. It raises the entry threshold. This is the reference to #6948.
Issues Resolved
#6845
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.