Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maintainers List #6692

Merged

Conversation

anasalkouz
Copy link
Member

Description

Update the list of maintainers

Issues Resolved

Resolves #6319

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anas Alkouz <aalkouz@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ad823b6). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #6692   +/-   ##
=======================================
  Coverage        ?   70.77%           
  Complexity      ?    59250           
=======================================
  Files           ?     4809           
  Lines           ?   283455           
  Branches        ?    40868           
=======================================
  Hits            ?   200612           
  Misses          ?    66384           
  Partials        ?    16459           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anasalkouz anasalkouz merged commit 62157b9 into opensearch-project:main Mar 15, 2023
@anasalkouz anasalkouz deleted the updateMaintainersList branch March 15, 2023 22:14
@dreamer-89
Copy link
Member

@anasalkouz : I believe we need to backport this change to 2.x and 1.x ?

@anasalkouz anasalkouz added the backport 2.x Backport to 2.x branch label Mar 16, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6692-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62157b93d297f30a922c462a74310c7578ee4537
# Push it to GitHub
git push --set-upstream origin backport/backport-6692-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6692-to-2.x.

mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
5 participants