Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test case - string profiler via global ordinals #5652

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

dbwiddis
Copy link
Member

Signed-off-by: Daniel Widdis widdis@gmail.com

Description

The "string profiler via global ordinals" rest test assumes all documents are in the same segment. The four commits occasionally are entered into multiple segments. PR #2226 by @penghuo attempted to fix this using a force merge, which reduced the frequency of these failures but did not eliminate them (reproduced once in 1000 runs).

Setting the flush boolean to true in this force merge completely resolves these failures (no repro in 2000 runs).

Issues Resolved

Fixes #1817
Improves fix of #2176

Check List

- [ ] New functionality includes testing.
- [ ] All tests pass
- [ ] New functionality has been documented.
- [ ] New functionality has javadoc added

  • Commits are signed per the DCO using --signoff
    - [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5652 (f215ea3) into main (d388051) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5652      +/-   ##
============================================
- Coverage     71.01%   70.98%   -0.04%     
- Complexity    58562    58621      +59     
============================================
  Files          4760     4760              
  Lines        279514   279514              
  Branches      40348    40348              
============================================
- Hits         198501   198412      -89     
- Misses        64815    64925     +110     
+ Partials      16198    16177      -21     
Impacted Files Coverage Δ
...port/ResponseHandlerFailureTransportException.java 0.00% <0.00%> (-60.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
.../java/org/opensearch/search/dfs/AggregatedDfs.java 54.83% <0.00%> (-41.94%) ⬇️
...ava/org/opensearch/search/dfs/DfsSearchResult.java 47.87% <0.00%> (-39.37%) ⬇️
...opensearch/index/reindex/BulkByScrollResponse.java 48.38% <0.00%> (-29.04%) ⬇️
.../java/org/opensearch/index/reindex/RemoteInfo.java 51.37% <0.00%> (-28.45%) ⬇️
...a/org/opensearch/index/mapper/MapperException.java 75.00% <0.00%> (-25.00%) ⬇️
...opensearch/snapshots/SnapshotRestoreException.java 25.00% <0.00%> (-25.00%) ⬇️
...ensearch/client/indices/DetailAnalyzeResponse.java 20.54% <0.00%> (-24.66%) ⬇️
...pensearch/index/mapper/MapperParsingException.java 77.77% <0.00%> (-22.23%) ⬇️
... and 473 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrross andrross merged commit 30ac284 into opensearch-project:main Dec 28, 2022
@andrross andrross added the backport 2.x Backport to 2.x branch label Dec 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 28, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 30ac284)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Dec 29, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 30ac284)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 30ac284)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis dbwiddis deleted the yamlRestTest branch January 31, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] :rest-api-spec:yamlRestTest org.opensearch.test.rest.ClientYamlTestSuiteIT intermittent failure
3 participants