Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spotless exclusion for HyperLogLogPlusPlus #5225

Merged

Conversation

andrross
Copy link
Member

The large data tables necessitating this exclusion were refactored away a long time ago.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The large data tables necessitating this exclusion were refactored away
a long time ago.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross requested review from a team and reta as code owners November 12, 2022 00:11
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

#5221

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5225 (d5d0a7c) into main (831b3a0) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #5225      +/-   ##
============================================
+ Coverage     70.97%   71.03%   +0.05%     
- Complexity    58186    58194       +8     
============================================
  Files          4708     4708              
  Lines        277558   277558              
  Branches      40190    40190              
============================================
+ Hits         197006   197168     +162     
+ Misses        64444    64224     -220     
- Partials      16108    16166      +58     
Impacted Files Coverage Δ
...arch/aggregations/metrics/HyperLogLogPlusPlus.java 92.48% <100.00%> (-1.74%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 55.55% <0.00%> (-44.45%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java 51.72% <0.00%> (-37.94%) ⬇️
...ations/bucket/terms/heuristic/PercentageScore.java 17.39% <0.00%> (-34.79%) ⬇️
...arch/search/aggregations/pipeline/SimpleModel.java 38.46% <0.00%> (-30.77%) ⬇️
...cluster/routing/allocation/RerouteExplanation.java 70.00% <0.00%> (-30.00%) ⬇️
... and 459 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrross andrross added the backport 2.x Backport to 2.x branch label Nov 14, 2022
@andrross andrross merged commit 671820d into opensearch-project:main Nov 14, 2022
@andrross andrross added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Nov 14, 2022
@andrross andrross deleted the remove-spotless-exclusion branch November 14, 2022 19:52
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2022
The large data tables necessitating this exclusion were refactored away
a long time ago.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 671820d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Nov 15, 2022
The large data tables necessitating this exclusion were refactored away
a long time ago.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 671820d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants