-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spotless exclusion for HyperLogLogPlusPlus #5225
Merged
andrross
merged 1 commit into
opensearch-project:main
from
andrross:remove-spotless-exclusion
Nov 14, 2022
Merged
Remove spotless exclusion for HyperLogLogPlusPlus #5225
andrross
merged 1 commit into
opensearch-project:main
from
andrross:remove-spotless-exclusion
Nov 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The large data tables necessitating this exclusion were refactored away a long time ago. Signed-off-by: Andrew Ross <andrross@amazon.com>
adnapibar
approved these changes
Nov 12, 2022
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5225 +/- ##
============================================
+ Coverage 70.97% 71.03% +0.05%
- Complexity 58186 58194 +8
============================================
Files 4708 4708
Lines 277558 277558
Branches 40190 40190
============================================
+ Hits 197006 197168 +162
+ Misses 64444 64224 -220
- Partials 16108 16166 +58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
approved these changes
Nov 12, 2022
andrross
added
backport 2.x
Backport to 2.x branch
and removed
backport 2.x
Backport to 2.x branch
labels
Nov 14, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2022
The large data tables necessitating this exclusion were refactored away a long time ago. Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 671820d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Nov 15, 2022
The large data tables necessitating this exclusion were refactored away a long time ago. Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 671820d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The large data tables necessitating this exclusion were refactored away a long time ago.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.