Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [BUG] Gradle Check Failed on Windows due to JDK19 pulling by gradle #5191

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 650039c from #5188.

…5188)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 650039c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners November 10, 2022 00:31
@reta
Copy link
Collaborator

reta commented Nov 10, 2022

@dblock the 2.x / 2.4 builds are not affected (since the failure was caused by the change in Gradle behavior) but this is a bug anyway, would be good to fix it now and never come back to it :)

@reta reta added backport PRs or issues specific to backporting features or enhancments skip-changelog labels Nov 10, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5191 (650039c) into 2.x (73af856) will increase coverage by 0.27%.
The diff coverage is 53.42%.

❗ Current head 650039c differs from pull request most recent head 6309807. Consider uploading reports for the commit 6309807 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #5191      +/-   ##
============================================
+ Coverage     70.70%   70.98%   +0.27%     
+ Complexity    58315    58169     -146     
============================================
  Files          4700     4708       +8     
  Lines        279112   277559    -1553     
  Branches      40748    40189     -559     
============================================
- Hits         197360   197016     -344     
+ Misses        65251    64385     -866     
+ Partials      16501    16158     -343     
Impacted Files Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java 0.00% <0.00%> (ø)
...nsearch/gradle/precommit/LicenseHeadersTask.groovy 0.00% <ø> (ø)
.../java/org/opensearch/gradle/JdkDownloadPlugin.java 37.36% <0.00%> (ø)
...ternal/InternalDistributionArchiveCheckPlugin.java 0.00% <0.00%> (ø)
...ternal/InternalDistributionArchiveSetupPlugin.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/FilePermissionsTask.java 78.78% <ø> (ø)
...search/gradle/precommit/ForbiddenPatternsTask.java 88.40% <ø> (ø)
...g/opensearch/gradle/precommit/LoggerUsageTask.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% <0.00%> (ø)
...ensearch/gradle/tar/SymbolicLinkPreservingTar.java 0.00% <0.00%> (ø)
... and 928 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta added backport PRs or issues specific to backporting features or enhancments and removed backport PRs or issues specific to backporting features or enhancments labels Nov 10, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Nov 10, 2022

#5189

@reta reta merged commit 083890f into 2.x Nov 10, 2022
@github-actions github-actions bot deleted the backport/backport-5188-to-2.x branch November 10, 2022 15:36
@dblock
Copy link
Member

dblock commented Nov 10, 2022

Gradle Check (Jenkins) Run Completed with:

#5198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants