-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Add IAE test for deprecated edgeNGram analyzer name #5040
Merged
nknize
merged 3 commits into
opensearch-project:main
from
nknize:fix/edgeNGramAnalyzerException
Nov 2, 2022
Merged
[Test] Add IAE test for deprecated edgeNGram analyzer name #5040
nknize
merged 3 commits into
opensearch-project:main
from
nknize:fix/edgeNGramAnalyzerException
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgeNGram was deprecated in legacy versions. In preparation for removal in the next major version, and IAE is thrown. This commit adds a test to ensure the IAE logic remains intact until removal. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added
:test
Adding or fixing a test
non-issue
bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
v3.0.0
Issues and PRs related to version 3.0.0
labels
Nov 2, 2022
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
reta
reviewed
Nov 2, 2022
...analysis-common/src/main/java/org/opensearch/analysis/common/CommonAnalysisModulePlugin.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
another #3603
|
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
reta
approved these changes
Nov 2, 2022
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edgeNGram
analyzer name was deprecated in legacy versions. In preparation for removal in the next major opensearch version,an IAE is thrown. This commit adds a test to ensure the IAE logic remains intact until removal.