Compatibility issue with /_mget: RHLC 2.x connected to OpenSearch Cluster 1.x #4812

reta · 2022-10-17T16:25:34Z

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

There is a compatibility issue with /_mget API: RHLC 2.x connected to OpenSearch Cluster 1.x, which basically renders the API unusable in certain cases, ending up with NullPointerException.

Exception in thread "main" java.io.IOException: Unable to parse response body for Response{requestLine=POST /_mget HTTP/1.1, host=http://localhost:9200, response=HTTP/1.1 200 OK}
	at org.opensearch.client.RestHighLevelClient.internalPerformRequest(RestHighLevelClient.java:1777)
	at org.opensearch.client.RestHighLevelClient.performRequest(RestHighLevelClient.java:1724)
	at org.opensearch.client.RestHighLevelClient.performRequestAndParseEntity(RestHighLevelClient.java:1692)
	at org.opensearch.client.RestHighLevelClient.mget(RestHighLevelClient.java:751)
	at io.aven.opensearch.client_runners.RestClientMultigetRunner.main(RestClientMultigetRunner.java:29)
Caused by: java.lang.NullPointerException
	at org.opensearch.index.get.GetResult.fromXContentEmbedded(GetResult.java:411)
	at org.opensearch.action.get.MultiGetResponse.parseItem(MultiGetResponse.java:216)
	at org.opensearch.action.get.MultiGetResponse.fromXContent(MultiGetResponse.java:189)
	at org.opensearch.client.RestHighLevelClient.parseEntity(RestHighLevelClient.java:2075)
	at org.opensearch.client.RestHighLevelClient.lambda$performRequestAndParseEntity$8(RestHighLevelClient.java:1692)
	at org.opensearch.client.RestHighLevelClient.internalPerformRequest(RestHighLevelClient.java:1775)
	... 4 more

Issues Resolved

Closes #4749

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-10-17T16:29:39Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4786/
CommitID: 682ef0d

github-actions · 2022-10-17T17:00:07Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4787/
CommitID: ee492de

github-actions · 2022-10-17T17:36:28Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4797/
CommitID: ee492de

codecov-commenter · 2022-10-17T17:38:51Z

Codecov Report

Merging #4812 (1307e4b) into main (cdc7a2f) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #4812      +/-   ##
============================================
- Coverage     70.74%   70.71%   -0.04%     
- Complexity    57888    57898      +10     
============================================
  Files          4689     4689              
  Lines        277305   277298       -7     
  Branches      40370    40364       -6     
============================================
- Hits         196190   196091      -99     
- Misses        64794    64967     +173     
+ Partials      16321    16240      -81

Impacted Files	Coverage Δ
...reness/get/GetDecommissionStateRequestBuilder.java	`0.00% <0.00%> (ø)`
...eness/get/TransportGetDecommissionStateAction.java	`23.07% <0.00%> (-1.93%)`	⬇️
.../org/opensearch/client/support/AbstractClient.java	`32.30% <ø> (-0.24%)`	⬇️
.../admin/cluster/RestGetDecommissionStateAction.java	`42.85% <25.00%> (-17.15%)`	⬇️
...on/awareness/get/GetDecommissionStateResponse.java	`42.85% <47.36%> (-1.92%)`	⬇️
...va/org/opensearch/action/get/MultiGetResponse.java	`70.32% <50.00%> (-0.46%)`	⬇️
...ion/awareness/get/GetDecommissionStateRequest.java	`82.35% <83.33%> (+82.35%)`	⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java	`0.00% <0.00%> (-75.00%)`	⬇️
...readonly/TransportVerifyShardIndexBlockAction.java	`9.75% <0.00%> (-58.54%)`	⬇️
...ava/org/opensearch/action/NoSuchNodeException.java	`0.00% <0.00%> (-50.00%)`	⬇️
... and 468 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

reta · 2022-10-17T18:25:21Z

server/src/main/java/org/opensearch/action/get/MultiGetResponse.java

+    // In mixed clusters, the 1.x cluster could still return the '_type' in the response payload, it has to
+    // be handled gracefully
+    @Deprecated(forRemoval = true)
+    private static final ParseField TYPE = new ParseField("_type");


@nknize no objections for this change from your side? thank you!

no objections since it's a compatibility issue! Especially w/ the clear deprecation. Nice!

github-actions · 2022-10-18T19:48:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4865/
CommitID: 1307e4b

nknize

Nice to have the additional testing! Thx!

nknize · 2022-10-20T12:32:35Z

server/src/main/java/org/opensearch/action/get/MultiGetResponse.java

+    // In mixed clusters, the 1.x cluster could still return the '_type' in the response payload, it has to
+    // be handled gracefully
+    @Deprecated(forRemoval = true)
+    private static final ParseField TYPE = new ParseField("_type");


no objections since it's a compatibility issue! Especially w/ the clear deprecation. Nice!

github-actions · 2022-10-20T21:46:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5119/
CommitID: 1a05e26

dblock · 2022-10-21T15:48:11Z

I believe this has been fixed in #4270, rebase?

…ster 1.x Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

github-actions · 2022-10-21T20:39:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5231/
CommitID: 1a05e26

github-actions · 2022-10-21T20:46:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5233/
CommitID: c5b9401

opensearch-trigger-bot · 2022-10-21T20:48:23Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1