[Bug]: gradle check failing with java heap OutOfMemoryError

[reta]

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

gradle check failing with java heap OutOfMemoryError

Issues Resolved

Closes #3973

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1508/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1516/
• CommitID: 21df1fa

[codecov-commenter]

Codecov Report

Merging #4150 (21df1fa) into main (203f44e) will increase coverage by 1.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4150      +/-   ##
============================================
+ Coverage     70.48%   71.71%   +1.23%     
- Complexity    57004    57944     +940     
============================================
  Files          4603     4603              
  Lines        274500   274500              
  Branches      40206    40206              
============================================
+ Hits         193477   196867    +3390     
+ Misses        64768    61956    -2812     
+ Partials      16255    15677     -578     

Impacted Files	Coverage Δ
...ava/org/opensearch/ingest/RandomDocumentPicks.java	81.63% <0.00%> (-6.13%)	⬇️
...pensearch/action/search/TransportSearchAction.java	71.23% <0.00%> (-5.54%)	⬇️
...pensearch/index/query/IntervalsSourceProvider.java	90.01% <0.00%> (+0.15%)	⬆️
...ensearch/index/query/MoreLikeThisQueryBuilder.java	81.45% <0.00%> (+0.17%)	⬆️
.../java/org/opensearch/common/settings/Settings.java	80.62% <0.00%> (+0.19%)	⬆️
...ensearch/gateway/PersistedClusterStateService.java	89.20% <0.00%> (+0.23%)	⬆️
...rg/opensearch/action/bulk/TransportBulkAction.java	77.48% <0.00%> (+0.23%)	⬆️
...org/opensearch/index/shard/IndexShardTestCase.java	94.04% <0.00%> (+0.25%)	⬆️
...ava/org/opensearch/test/AbstractQueryTestCase.java	88.72% <0.00%> (+0.28%)	⬆️
...ain/java/org/opensearch/ingest/IngestDocument.java	90.53% <0.00%> (+0.29%)	⬆️
... and 563 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[CEHENKLE]

Aaaah! That's awesome, @reta !!!!! Nice catch!!!!!!

[reta]

Aaaah! That's awesome, @reta !!!!! Nice catch!!!!!!

Thanks @CEHENKLE , I will keep it as draft for some time, will rerun builds to see if issue is gone

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1522/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1523/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1525/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1526/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1531/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/1541/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1567/
• CommitID: 21df1fa

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1568/
• CommitID: 21df1fa

[bbarani]

@reta lets merge this fix in soon as I don't see any risk here.

[reta]

@reta lets merge this fix in soon as I don't see any risk here.

@bbarani no objections, have not seen JVM heap issues so far on this pull request

[peterzhuamazon]

@reta @saratvemulapalli this seems like a change that can backport to 2.0/2.1/2.2/2.x/1.3/1.x branches.
Thoughts?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/1600/
• CommitID: 21df1fa

[saratvemulapalli]

@peterzhuamazon yeah I agree. This fix probably helps all builds.

[opensearch-trigger-bot]

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-4150-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f2ed704577d6a8a2fa95ee7c110dd7a2b91a141
# Push it to GitHub
git push --set-upstream origin backport/backport-4150-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-4150-to-1.x.

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-4150-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f2ed704577d6a8a2fa95ee7c110dd7a2b91a141
# Push it to GitHub
git push --set-upstream origin backport/backport-4150-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-4150-to-1.3.

[peterzhuamazon]

@reta seems like 1.x/1.3 failed could you manually backport to those branches?
Thanks.