[Segment Replication] Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…rviceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…cating() test case Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…to main Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
kartg
reviewed
Jul 20, 2022
| @@ -172,6 +172,10 @@ public void run() { | |||
|
|
|||
| private void start(final long replicationId) { | |||
| try (ReplicationRef<SegmentReplicationTarget> replicationRef = onGoingReplications.get(replicationId)) { | |||
| if (replicationRef == null) { | |||
| logger.trace("Cannot find any running replication with id [{}]", replicationId); | |||
There was a problem hiding this comment.
I don't think a log line is necessary here. Just include a comment that this is for handling edge cases where the reference is removed before the ReplicationRunner is started by the threadpool.
kartg
approved these changes
Jul 20, 2022
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #3963 +/- ##
============================================
- Coverage 70.68% 70.50% -0.18%
+ Complexity 56835 56721 -114
============================================
Files 4573 4573
Lines 273255 273258 +3
Branches 40076 40078 +2
============================================
- Hits 193143 192655 -488
- Misses 63871 64418 +547
+ Partials 16241 16185 -56
|
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
dreamer-89
approved these changes
Jul 21, 2022
Rishikesh1159
changed the title
Rishikesh1159
added a commit
to Rishikesh1159/OpenSearch
that referenced
this pull request
Aug 10, 2022
…Replications() (opensearch-project#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Rishikesh1159
added a commit
to Rishikesh1159/OpenSearch
that referenced
this pull request
Aug 10, 2022
…Replications() (opensearch-project#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Rishikesh1159
added a commit
that referenced
this pull request
Aug 11, 2022
…#3943 #3963 From main branch (#4181) * Resolving import conflict in Node.java and mergining PR #3525. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Resolving conflicts and merging PR #3533. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Resolving conflicts and Merging PR #3540. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotlesscheck and fixing wildcard imports. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * [Segment Replication] Fixing flaky test failure happening for testShardAlreadyReplicating() (#3943) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() (#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Removing assert segrep() in getProcessedLocalCheckpoint() of Index.shard class. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Revert "Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests." Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> This reverts commit 8c5753b. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Co-authored-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Poojita Raj <poojiraj@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes possible flaky test failure for testBeforeIndexShardClosed_CancelsOngoingReplications() by adding null check
Issues Resolved
Related to #3872
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.