Adds a new parameter, max_analyzer_offset, for the highlighter #3893

hauck-jvsh · 2022-07-13T22:48:31Z

Description

Adds a new parameter, max_analyzer_offset, for the highlighter. This new parameter can be used to avoid aborting when highlighting large fields, or just to speedup the highlight doing it only on the beginning of the field.

Issues Resolved

This pull request closes #3842

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hauck-jvsh · 2022-07-13T22:52:47Z

I couldn't run the check on windows, it was failing even when I run it with the main branch I executed the line below on powershell.

gradlew.bat check

Finally, how can I signed the commits?

github-actions · 2022-07-13T23:11:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/560/
CommitID: d799b6be0fbcd4a9705ac586b0edb36c9f55c4b7

github-actions · 2022-07-13T23:39:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/564/
CommitID: 5493a142062b8a67f87a33494f0c5da86131a813

hauck-jvsh · 2022-07-14T12:46:16Z

I see that tests are failing for multi cluster searches. However this is expected, as these other clusters did not support this feature. Is there an way to check te cluster version and only runs this when all clusters support it?

dblock · 2022-07-14T17:30:18Z

For DCO, amend your PRs with -s. Not sure about the other questions, @andrross do you know how to do this properly?

andrross · 2022-07-14T19:20:19Z

For DCO, amend your PRs with -s. Not sure about the other questions, @andrross do you know how to do this properly?

Do you need to add something like this to your test specification (substituting the correct version of course)?

…max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com>

Signed-off-by: Hauck <joaoh14@gmail.com>

github-actions · 2022-07-15T03:17:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/659/
CommitID: 595bb04

github-actions · 2022-07-15T03:30:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/660/
CommitID: 1b63fad

Signed-off-by: Hauck <joaoh14@gmail.com>

github-actions · 2022-07-15T05:06:16Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/662/
CommitID: ba381be

Signed-off-by: Hauck <joaoh14@gmail.com>

github-actions · 2022-07-15T06:00:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/671/
CommitID: c63d527

github-actions · 2022-07-15T14:54:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/687/
CommitID: 37be5e93f9485318ecc811e78a73de515887d144

codecov-commenter · 2022-07-15T14:55:16Z

Codecov Report

Merging #3893 (4b25f5c) into main (07775ff) will increase coverage by 0.08%.
The diff coverage is 62.73%.

@@             Coverage Diff              @@
##               main    #3893      +/-   ##
============================================
+ Coverage     70.57%   70.66%   +0.08%     
- Complexity    56679    56795     +116     
============================================
  Files          4563     4573      +10     
  Lines        272755   273288     +533     
  Branches      40040    40084      +44     
============================================
+ Hits         192505   193116     +611     
+ Misses        64014    63905     -109     
- Partials      16236    16267      +31

Impacted Files	Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java	`0.00% <ø> (ø)`
...a/org/opensearch/painless/antlr/PainlessLexer.java	`68.18% <ø> (ø)`
.../org/opensearch/painless/antlr/PainlessParser.java	`68.43% <ø> (ø)`
...earch/action/search/PitSearchContextIdForNode.java	`0.00% <0.00%> (ø)`
...ensearch/action/search/SearchContextIdForNode.java	`94.44% <ø> (ø)`
...er/src/main/java/org/opensearch/client/Client.java	`40.00% <ø> (ø)`
.../org/opensearch/client/support/AbstractClient.java	`34.96% <0.00%> (-0.19%)`	⬇️
...rg/opensearch/common/settings/ClusterSettings.java	`91.89% <ø> (ø)`
...pensearch/common/settings/IndexScopedSettings.java	`100.00% <ø> (ø)`
...rch/fetch/subphase/highlight/HighlightBuilder.java	`94.37% <0.00%> (-0.39%)`	⬇️
... and 513 more

Signed-off-by: Hauck <joaoh14@gmail.com>

github-actions · 2022-07-15T15:20:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/688/
CommitID: ed80f5f

server/src/main/java/org/opensearch/search/fetch/subphase/highlight/UnifiedHighlighter.java

github-actions · 2022-07-18T13:34:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/733/
CommitID: 24dec06

hauck-jvsh · 2022-07-18T14:12:18Z

Do you think this can be back-ported to 2.x?

github-actions · 2022-07-20T03:40:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/811/
CommitID: f2ef792

rest-api-spec/src/main/resources/rest-api-spec/test/search.highlight/30_max_analyzed_offset.yml

andrross · 2022-07-20T23:38:09Z

Do you think this can be back-ported to 2.x?

I think so. Since it's a new parameter it's fully backward compatible. @reta do you see any reason not to backport?

Signed-off-by: Hauck <joaoh14@gmail.com>

github-actions · 2022-07-21T02:07:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/857/
CommitID: 4b25f5c

dblock · 2022-07-21T20:03:07Z

@andrross all yours to final review/merge

@reta

* #3842 adds a new parameter to the highlighter, the max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com> * Adds a test for the new parameter Signed-off-by: Hauck <joaoh14@gmail.com> * Fix the test add in the previous commit; Signed-off-by: Hauck <joaoh14@gmail.com> * This was checking against the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Only runs the test for the correct version Signed-off-by: Hauck <joaoh14@gmail.com> * Skips the test in Elasticsearch as well; Signed-off-by: Hauck <joaoh14@gmail.com> * Remove elastic 3.0 to test Signed-off-by: Hauck <joaoh14@gmail.com> * Skips all versions Signed-off-by: Hauck <joaoh14@gmail.com> * Remove unnecessary fields as pointed by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * Compute if fieldMaxAnalyzedIsNotValid in the constructor as suggest by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * As discussed, it is better to throws different exceptions for when the fieldMaxAnalyzed is not valid and for when it is disabled; Signed-off-by: Hauck <joaoh14@gmail.com> * hint what to do to allow highlight of bigger documents Signed-off-by: Hauck <joaoh14@gmail.com> * Let the user define the new parameter globally for all fields highlighted Signed-off-by: Hauck <joaoh14@gmail.com> * Change the fieldMaxAnalyzedOffset Integer in order to use null when it is absent in highlight. This allows the error messages to much more precise, showing invalid for all negative numbers; Signed-off-by: Hauck <joaoh14@gmail.com> * Update javadocs and implements the stream methods for the new fields; Signed-off-by: Hauck <joaoh14@gmail.com> * builder.field do not accept null, so check before calling the method is necessary Signed-off-by: Hauck <joaoh14@gmail.com> * Only send and read the new fields if the version supports it Signed-off-by: Hauck <joaoh14@gmail.com> * the previous commit was checking the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Check for version 3.0.0 instead of current version Signed-off-by: Hauck <joaoh14@gmail.com> * Update server/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Hauck <joaoh14@gmail.com> * Execute the test after version 3.0.0 Signed-off-by: Hauck <joaoh14@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 931813f)

reta · 2022-07-24T16:15:18Z

Do you think this can be back-ported to 2.x?

I think so. Since it's a new parameter it's fully backward compatible. @reta do you see any reason not to backport?

No, I don't see any reasons not to backport, it is good change I think.

@reta

…earch-project#3893) * opensearch-project#3842 adds a new parameter to the highlighter, the max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com> * Adds a test for the new parameter Signed-off-by: Hauck <joaoh14@gmail.com> * Fix the test add in the previous commit; Signed-off-by: Hauck <joaoh14@gmail.com> * This was checking against the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Only runs the test for the correct version Signed-off-by: Hauck <joaoh14@gmail.com> * Skips the test in Elasticsearch as well; Signed-off-by: Hauck <joaoh14@gmail.com> * Remove elastic 3.0 to test Signed-off-by: Hauck <joaoh14@gmail.com> * Skips all versions Signed-off-by: Hauck <joaoh14@gmail.com> * Remove unnecessary fields as pointed by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * Compute if fieldMaxAnalyzedIsNotValid in the constructor as suggest by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * As discussed, it is better to throws different exceptions for when the fieldMaxAnalyzed is not valid and for when it is disabled; Signed-off-by: Hauck <joaoh14@gmail.com> * hint what to do to allow highlight of bigger documents Signed-off-by: Hauck <joaoh14@gmail.com> * Let the user define the new parameter globally for all fields highlighted Signed-off-by: Hauck <joaoh14@gmail.com> * Change the fieldMaxAnalyzedOffset Integer in order to use null when it is absent in highlight. This allows the error messages to much more precise, showing invalid for all negative numbers; Signed-off-by: Hauck <joaoh14@gmail.com> * Update javadocs and implements the stream methods for the new fields; Signed-off-by: Hauck <joaoh14@gmail.com> * builder.field do not accept null, so check before calling the method is necessary Signed-off-by: Hauck <joaoh14@gmail.com> * Only send and read the new fields if the version supports it Signed-off-by: Hauck <joaoh14@gmail.com> * the previous commit was checking the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Check for version 3.0.0 instead of current version Signed-off-by: Hauck <joaoh14@gmail.com> * Update server/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Hauck <joaoh14@gmail.com> * Execute the test after version 3.0.0 Signed-off-by: Hauck <joaoh14@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 931813f) Signed-off-by: Hauck <joaoh14@gmail.com>

@reta

…hlighter (#4031) * Adds a new parameter, max_analyzer_offset, for the highlighter (#3893) * #3842 adds a new parameter to the highlighter, the max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com> * Adds a test for the new parameter Signed-off-by: Hauck <joaoh14@gmail.com> * Fix the test add in the previous commit; Signed-off-by: Hauck <joaoh14@gmail.com> * This was checking against the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Only runs the test for the correct version Signed-off-by: Hauck <joaoh14@gmail.com> * Skips the test in Elasticsearch as well; Signed-off-by: Hauck <joaoh14@gmail.com> * Remove elastic 3.0 to test Signed-off-by: Hauck <joaoh14@gmail.com> * Skips all versions Signed-off-by: Hauck <joaoh14@gmail.com> * Remove unnecessary fields as pointed by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * Compute if fieldMaxAnalyzedIsNotValid in the constructor as suggest by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * As discussed, it is better to throws different exceptions for when the fieldMaxAnalyzed is not valid and for when it is disabled; Signed-off-by: Hauck <joaoh14@gmail.com> * hint what to do to allow highlight of bigger documents Signed-off-by: Hauck <joaoh14@gmail.com> * Let the user define the new parameter globally for all fields highlighted Signed-off-by: Hauck <joaoh14@gmail.com> * Change the fieldMaxAnalyzedOffset Integer in order to use null when it is absent in highlight. This allows the error messages to much more precise, showing invalid for all negative numbers; Signed-off-by: Hauck <joaoh14@gmail.com> * Update javadocs and implements the stream methods for the new fields; Signed-off-by: Hauck <joaoh14@gmail.com> * builder.field do not accept null, so check before calling the method is necessary Signed-off-by: Hauck <joaoh14@gmail.com> * Only send and read the new fields if the version supports it Signed-off-by: Hauck <joaoh14@gmail.com> * the previous commit was checking the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Check for version 3.0.0 instead of current version Signed-off-by: Hauck <joaoh14@gmail.com> * Update server/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Hauck <joaoh14@gmail.com> * Execute the test after version 3.0.0 Signed-off-by: Hauck <joaoh14@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 931813f) Signed-off-by: Hauck <joaoh14@gmail.com> * Fix the version tests Signed-off-by: Hauck <joaoh14@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com>

@reta

* #3842 adds a new parameter to the highlighter, the max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com> * Adds a test for the new parameter Signed-off-by: Hauck <joaoh14@gmail.com> * Fix the test add in the previous commit; Signed-off-by: Hauck <joaoh14@gmail.com> * This was checking against the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Only runs the test for the correct version Signed-off-by: Hauck <joaoh14@gmail.com> * Skips the test in Elasticsearch as well; Signed-off-by: Hauck <joaoh14@gmail.com> * Remove elastic 3.0 to test Signed-off-by: Hauck <joaoh14@gmail.com> * Skips all versions Signed-off-by: Hauck <joaoh14@gmail.com> * Remove unnecessary fields as pointed by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * Compute if fieldMaxAnalyzedIsNotValid in the constructor as suggest by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * As discussed, it is better to throws different exceptions for when the fieldMaxAnalyzed is not valid and for when it is disabled; Signed-off-by: Hauck <joaoh14@gmail.com> * hint what to do to allow highlight of bigger documents Signed-off-by: Hauck <joaoh14@gmail.com> * Let the user define the new parameter globally for all fields highlighted Signed-off-by: Hauck <joaoh14@gmail.com> * Change the fieldMaxAnalyzedOffset Integer in order to use null when it is absent in highlight. This allows the error messages to much more precise, showing invalid for all negative numbers; Signed-off-by: Hauck <joaoh14@gmail.com> * Update javadocs and implements the stream methods for the new fields; Signed-off-by: Hauck <joaoh14@gmail.com> * builder.field do not accept null, so check before calling the method is necessary Signed-off-by: Hauck <joaoh14@gmail.com> * Only send and read the new fields if the version supports it Signed-off-by: Hauck <joaoh14@gmail.com> * the previous commit was checking the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Check for version 3.0.0 instead of current version Signed-off-by: Hauck <joaoh14@gmail.com> * Update server/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Hauck <joaoh14@gmail.com> * Execute the test after version 3.0.0 Signed-off-by: Hauck <joaoh14@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 931813f)

@reta

* #3842 adds a new parameter to the highlighter, the max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com> * Adds a test for the new parameter Signed-off-by: Hauck <joaoh14@gmail.com> * Fix the test add in the previous commit; Signed-off-by: Hauck <joaoh14@gmail.com> * This was checking against the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Only runs the test for the correct version Signed-off-by: Hauck <joaoh14@gmail.com> * Skips the test in Elasticsearch as well; Signed-off-by: Hauck <joaoh14@gmail.com> * Remove elastic 3.0 to test Signed-off-by: Hauck <joaoh14@gmail.com> * Skips all versions Signed-off-by: Hauck <joaoh14@gmail.com> * Remove unnecessary fields as pointed by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * Compute if fieldMaxAnalyzedIsNotValid in the constructor as suggest by @reta Signed-off-by: Hauck <joaoh14@gmail.com> * As discussed, it is better to throws different exceptions for when the fieldMaxAnalyzed is not valid and for when it is disabled; Signed-off-by: Hauck <joaoh14@gmail.com> * hint what to do to allow highlight of bigger documents Signed-off-by: Hauck <joaoh14@gmail.com> * Let the user define the new parameter globally for all fields highlighted Signed-off-by: Hauck <joaoh14@gmail.com> * Change the fieldMaxAnalyzedOffset Integer in order to use null when it is absent in highlight. This allows the error messages to much more precise, showing invalid for all negative numbers; Signed-off-by: Hauck <joaoh14@gmail.com> * Update javadocs and implements the stream methods for the new fields; Signed-off-by: Hauck <joaoh14@gmail.com> * builder.field do not accept null, so check before calling the method is necessary Signed-off-by: Hauck <joaoh14@gmail.com> * Only send and read the new fields if the version supports it Signed-off-by: Hauck <joaoh14@gmail.com> * the previous commit was checking the wrong field Signed-off-by: Hauck <joaoh14@gmail.com> * Check for version 3.0.0 instead of current version Signed-off-by: Hauck <joaoh14@gmail.com> * Update server/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Hauck <joaoh14@gmail.com> * Execute the test after version 3.0.0 Signed-off-by: Hauck <joaoh14@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit 931813f)

JekoTarallo · 2023-07-26T09:01:13Z

May I ask if this fix was introduced in OpenSearch 2.5? Thanks in advance.

reta · 2023-07-26T13:21:24Z

@JekoTarallo

May I ask if this fix was introduced in OpenSearch 2.5? Thanks in advance.

As per issue labels, it should be available from 2.2.0 and above

JekoTarallo · 2023-07-27T13:33:15Z

Unfortunately I'm having this issue on both clusters of OpenSearch 2.5 and 2.7 on AWS, this is the error message that appears on Discover section when using whatever query:

illegal_argument_exception
The length of [message] field of [23595] doc of [index-test-log] index has exceeded [1000000] - maximum allowed to be analyzed for highlighting. This maximum can be set by changing the [index.highlight.max_analyzed_offset] index level setting. For large texts, indexing with offsets or term vectors is recommended!

hauck-jvsh · 2023-07-27T13:42:59Z

In your search query, are you passing the option "max_analyzer_offset": 100000?

JekoTarallo · 2023-07-27T13:46:03Z

I'm just doing a classic query:

When the query bar is empty the records are loaded, if I search anything I receive the error I mentioned before.

sharebear · 2024-05-02T08:46:38Z

Stupid question perhaps, but do I understand correctly that this is a setting that needs to be set per-query? How do we ensure this value is set when executing queries from OpenSearch Dasbhoards?

hauck-jvsh requested review from a team and reta as code owners July 13, 2022 22:48

tlfeng added enhancement Enhancement or improvement to existing feature or request community Issues raised by community members and contributors Indexing & Search labels Jul 14, 2022

dblock requested a review from andrross July 14, 2022 17:29

hauck-jvsh added 4 commits July 14, 2022 23:50

opensearch-project#3842 adds a new parameter to the highlighter, the …

f0d9805

…max_analyzer_offset. When this parameter is provided the highlight stops in its value. This prevents the highlighter to go beyond the index maxAnalyzedOffset. Signed-off-by: Hauck <joaoh14@gmail.com>

Adds a test for the new parameter

6be297d

Signed-off-by: Hauck <joaoh14@gmail.com>

Fix the test add in the previous commit;

4c6ff70

Signed-off-by: Hauck <joaoh14@gmail.com>

This was checking against the wrong field

595bb04

Signed-off-by: Hauck <joaoh14@gmail.com>

hauck-jvsh force-pushed the main branch from 5493a14 to 595bb04 Compare July 15, 2022 02:52

Only runs the test for the correct version

1b63fad

Signed-off-by: Hauck <joaoh14@gmail.com>

Skips the test in Elasticsearch as well;

ba381be

Signed-off-by: Hauck <joaoh14@gmail.com>

Remove elastic 3.0 to test

c63d527

Signed-off-by: Hauck <joaoh14@gmail.com>

Skips all versions

ed80f5f

Signed-off-by: Hauck <joaoh14@gmail.com>

hauck-jvsh force-pushed the main branch from 37be5e9 to ed80f5f Compare July 15, 2022 14:57

reta reviewed Jul 15, 2022

View reviewed changes

server/src/main/java/org/opensearch/search/fetch/subphase/highlight/UnifiedHighlighter.java Outdated Show resolved Hide resolved

Merge branch 'opensearch-project:main' into main

f2ef792

andrross reviewed Jul 20, 2022

View reviewed changes

rest-api-spec/src/main/resources/rest-api-spec/test/search.highlight/30_max_analyzed_offset.yml Outdated Show resolved Hide resolved

Execute the test after version 3.0.0

4b25f5c

Signed-off-by: Hauck <joaoh14@gmail.com>

dblock added the backport 2.x Backport to 2.x branch label Jul 21, 2022

dblock requested a review from andrross July 21, 2022 20:03

andrross approved these changes Jul 22, 2022

View reviewed changes

andrross merged commit 931813f into opensearch-project:main Jul 22, 2022

opensearch-trigger-bot bot mentioned this pull request Jul 22, 2022

[Backport 2.x] Adds a new parameter, max_analyzer_offset, for the highlighter #3986

Closed

schmittjoaopedro mentioned this pull request Jul 5, 2023

Fixes #553: fix max_analyzer_offset field to match OS 2.2.0 opensearch-project/opensearch-java#555

Merged

gjunge mentioned this pull request Aug 17, 2023

Fixes #321: fix highlight max_analyzer_offset field name to match OS 2.2.0 opensearch-project/opensearch-net#322

Merged

drunken-monkey mentioned this pull request Oct 18, 2023

[BUG] "max_analyzer_offset" highlight query setting not working for plain highlighter #10702

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds a new parameter, max_analyzer_offset, for the highlighter #3893

Adds a new parameter, max_analyzer_offset, for the highlighter #3893

hauck-jvsh commented Jul 13, 2022 •

edited

Loading

hauck-jvsh commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

hauck-jvsh commented Jul 14, 2022

dblock commented Jul 14, 2022

andrross commented Jul 14, 2022

github-actions bot commented Jul 15, 2022

github-actions bot commented Jul 15, 2022

github-actions bot commented Jul 15, 2022

github-actions bot commented Jul 15, 2022

github-actions bot commented Jul 15, 2022

codecov-commenter commented Jul 15, 2022 •

edited

Loading

github-actions bot commented Jul 15, 2022

github-actions bot commented Jul 18, 2022

hauck-jvsh commented Jul 18, 2022

github-actions bot commented Jul 20, 2022

andrross commented Jul 20, 2022

github-actions bot commented Jul 21, 2022

dblock commented Jul 21, 2022

reta commented Jul 24, 2022

JekoTarallo commented Jul 26, 2023

reta commented Jul 26, 2023

JekoTarallo commented Jul 27, 2023

hauck-jvsh commented Jul 27, 2023

JekoTarallo commented Jul 27, 2023

sharebear commented May 2, 2024

Adds a new parameter, max_analyzer_offset, for the highlighter #3893

Adds a new parameter, max_analyzer_offset, for the highlighter #3893

Conversation

hauck-jvsh commented Jul 13, 2022 • edited Loading

Description

Issues Resolved

Check List

hauck-jvsh commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 13, 2022

Gradle Check (Jenkins) Run Completed with:

hauck-jvsh commented Jul 14, 2022

dblock commented Jul 14, 2022

andrross commented Jul 14, 2022

github-actions bot commented Jul 15, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 15, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 15, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 15, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 15, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Jul 15, 2022 • edited Loading

Codecov Report

github-actions bot commented Jul 15, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 18, 2022

Gradle Check (Jenkins) Run Completed with:

hauck-jvsh commented Jul 18, 2022

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

andrross commented Jul 20, 2022

github-actions bot commented Jul 21, 2022

Gradle Check (Jenkins) Run Completed with:

dblock commented Jul 21, 2022

reta commented Jul 24, 2022

JekoTarallo commented Jul 26, 2023

reta commented Jul 26, 2023

JekoTarallo commented Jul 27, 2023

hauck-jvsh commented Jul 27, 2023

JekoTarallo commented Jul 27, 2023

sharebear commented May 2, 2024

hauck-jvsh commented Jul 13, 2022 •

edited

Loading

codecov-commenter commented Jul 15, 2022 •

edited

Loading