Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaxb-impl from 2.2.3-1 to 3.0.2 in /plugins/discovery-azure-classic #2271

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2022

Bumps jaxb-impl from 2.2.3-1 to 3.0.2.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 28, 2022 13:19
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 28, 2022
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 844be7e
Log 2856

Reports 2856

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c8308ca
Log 2865

Reports 2865

Bumps jaxb-impl from 2.2.3-1 to 3.0.2.

---
updated-dependencies:
- dependency-name: com.sun.xml.bind:jaxb-impl
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/plugins/discovery-azure-classic/com.sun.xml.bind-jaxb-impl-3.0.2 branch from c8308ca to bfcb175 Compare March 5, 2022 00:34
Signed-off-by: dependabot[bot] <support@github.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bfcb175
Log 3064

Reports 3064

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bc4f1eb
Log 3065

Reports 3065

@kartg
Copy link
Member

kartg commented Mar 7, 2022

Probably related to this section of ignoreMissingClasses

Refiring to verify

@kartg
Copy link
Member

kartg commented Mar 7, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bc4f1eb
Log 3121

Reports 3121

@kartg
Copy link
Member

kartg commented Mar 7, 2022

Confirmed that the class exclusions are the root cause of the failure:

Task :plugins:discovery-azure-classic:thirdPartyAudit
Unnecessary exclusions, following classes are not missing:
   * javax.activation.MimeType
   * javax.activation.MimeTypeParseException

....

* What went wrong:
 Execution failed for task ':plugins:discovery-azure-classic:thirdPartyAudit'.
 > Third party audit task is not configured correctly

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bc4f1eb
Log 3410

Reports 3410

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartg JAXB 3.x is targeting jakarta.* namespace, we should not merge this change

@dblock dblock closed this Mar 16, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 16, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/plugins/discovery-azure-classic/com.sun.xml.bind-jaxb-impl-3.0.2 branch March 16, 2022 15:26
@CEHENKLE
Copy link
Member

@kartg JAXB 3.x is targeting jakarta.* namespace, we should not merge this change

Thanks, @reta Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants