Expand streaming aggregations to numeric terms #19335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 26e87a1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Sep 18, 2025
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
expand_streaming_agg
branch
from
26e87a1 to
f0846d8
Compare
harshavamsi
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❕ Gradle check result for b0d6d72: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
❕ Gradle check result for 0fa9202: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
❌ Gradle check result for bcd751d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
server/src/main/java/org/opensearch/search/aggregations/bucket/BucketsAggregator.java
Show resolved
Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
.../main/java/org/opensearch/search/aggregations/bucket/terms/StreamNumericTermsAggregator.java
Show resolved
Hide resolved
rishabhmaurya
approved these changes
Oct 2, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
19 tasks
mkhludnev
reviewed
Oct 6, 2025
|
|
||
| public void testBuildAggregationsBatchWithSingleValuedOrds() throws Exception { | ||
| try (Directory directory = newDirectory()) { | ||
| try (IndexWriter indexWriter = new IndexWriter(directory, new IndexWriterConfig())) { |
There was a problem hiding this comment.
I suppose these tests should verify segmented index with RandomIndexWriter
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
) * Expand streaming aggregations to numeric terms Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changelog Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix gradle assemble Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * update test coverage Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * remove custom stream package Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * remove custom stream package Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * remove unused results Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #18874 where we added streaming capabilities for terms aggregation, this PR helps expand it to numeric terms as well.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.