Standardize setting key for aux transports #18452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Plugins integrating with AuxTransports need a way to identify transport types with a unique name. Specifically thinking in terms of security plugin where security settings for a transport will be configured under a namespace matching that transport. However since security plugin does have an authoritative list of aux transports it needs a way to fetch this "namespace key" from an AuxTransport isntance. Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
|
❌ Gradle check result for ca46db5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <carrofin@amazon.com>
|
@rishabhmaurya can you take a look when you have a chance? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18452 +/- ##
============================================
+ Coverage 72.74% 73.07% +0.33%
- Complexity 67864 68162 +298
============================================
Files 5507 5508 +1
Lines 312253 312256 +3
Branches 45348 45348
============================================
+ Hits 227137 228190 +1053
+ Misses 66618 65766 -852
+ Partials 18498 18300 -198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rishabhmaurya
approved these changes
Jun 5, 2025
github-project-automation
bot
moved this from Todo
to In Progress
in Performance Roadmap
|
@finnegancarroll Thank you, LGTM! please check the codecov report. |
Signed-off-by: Finn Carroll <carrofin@amazon.com>
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
github-project-automation
bot
moved this from Done
to In Progress
in Performance Roadmap
rishabhmaurya
approved these changes
Jun 9, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
* Refactor AuxTransport to org.opensearch.transport.AuxTransport. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Add enableKey identifier to AuxTransports. Plugins integrating with AuxTransports need a way to identify transport types with a unique name. Specifically thinking in terms of security plugin where security settings for a transport will be configured under a namespace matching that transport. However since security plugin does have an authoritative list of aux transports it needs a way to fetch this "namespace key" from an AuxTransport isntance. Signed-off-by: Finn Carroll <carrofin@amazon.com> * enableKey -> settingKey. Rename for clarity. Signed-off-by: Finn Carroll <carrofin@amazon.com> * ARROW_FLIGHT_TRANSPORT_SETTING_KEY to private. Javadocs.Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
* Refactor AuxTransport to org.opensearch.transport.AuxTransport. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Add enableKey identifier to AuxTransports. Plugins integrating with AuxTransports need a way to identify transport types with a unique name. Specifically thinking in terms of security plugin where security settings for a transport will be configured under a namespace matching that transport. However since security plugin does have an authoritative list of aux transports it needs a way to fetch this "namespace key" from an AuxTransport isntance. Signed-off-by: Finn Carroll <carrofin@amazon.com> * enableKey -> settingKey. Rename for clarity. Signed-off-by: Finn Carroll <carrofin@amazon.com> * ARROW_FLIGHT_TRANSPORT_SETTING_KEY to private. Javadocs.
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
* Refactor AuxTransport to org.opensearch.transport.AuxTransport. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Add enableKey identifier to AuxTransports. Plugins integrating with AuxTransports need a way to identify transport types with a unique name. Specifically thinking in terms of security plugin where security settings for a transport will be configured under a namespace matching that transport. However since security plugin does have an authoritative list of aux transports it needs a way to fetch this "namespace key" from an AuxTransport isntance. Signed-off-by: Finn Carroll <carrofin@amazon.com> * enableKey -> settingKey. Rename for clarity. Signed-off-by: Finn Carroll <carrofin@amazon.com> * ARROW_FLIGHT_TRANSPORT_SETTING_KEY to private. Javadocs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a few changes with the goal of making AuxTransport settings more easily configured/extended.
AuxTransportout ofNetworkPluginintoorg.opensearch.transport.AuxTransport.Minor refactor. All other transport base classes are in this package and AuxTransport a bit out of place in
NetworkPlugin.settingKeyaccessor to AuxTransport.Forward looking change for plugins which want to identify the namespace of AuxTransports.
(TLS support for auxiliary transports security#5375)
FlightStreamPluginwhich registers theFlightServiceAuxTransport under keyaux.transport.types.Moved this to
experimental-transport-arrow-flight-rpcwhich users will need to include underaux.transport.typessetting to enable this transport.Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.