Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star tree] Handle delete cases for star tree #16380

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Oct 18, 2024

Description

When there are delete operations in the index, there are segments where SegmentDocValuesProducers is present which contains List<DocValuesProducers> contrary to segments in index where no deletes are present.

So one change is to pick DocValuesProducer in the list where StarTreeValues is present - usually I see that one field is present only in one of the DocValuesProducer - even SegmentDocValuesProducer has a map of FieldInfo to DocValuesProducer which confirms the same.

Secondly there are issues because of segmentSuffix missing in the custom write state and read state. So have added the same.

Also including fixes from #16124

Related Issues

Resolves #16381

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
@bharath-techie
Copy link
Contributor Author

#16233 - if keyword changes are missing 2.18 timeframe, we will include only this particular PR which contains fixes. Marking the PR as draft for now.

@bharath-techie bharath-techie marked this pull request as draft October 18, 2024 10:31
Copy link
Contributor

❌ Gradle check result for 80dc4c4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 80dc4c4: SUCCESS

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (0bded88) to head (80dc4c4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...site/composite912/Composite912DocValuesWriter.java 36.36% 6 Missing and 1 partial ⚠️
...org/apache/lucene/index/DocValuesProducerUtil.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16380      +/-   ##
============================================
- Coverage     72.07%   71.96%   -0.12%     
+ Complexity    64819    64739      -80     
============================================
  Files          5307     5308       +1     
  Lines        302718   302724       +6     
  Branches      43734    43734              
============================================
- Hits         218178   217849     -329     
- Misses        66638    66972     +334     
- Partials      17902    17903       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Copy link
Member

Changes are covered in integ tests but CodeCov does not consider coverage from integ tests, bypassing the check.

@sachinpkale sachinpkale merged commit ad7f9e7 into opensearch-project:main Oct 21, 2024
43 of 47 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Oct 21, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
(cherry picked from commit ad7f9e7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit ad7f9e7)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Handle delete cases with star tree index
3 participants