[NOCOMMIT] Approximate match all query benchmark #16322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we run a match-all query and sort results by a numeric/timestamp field, then we can replace the match-all with a filter over the top/bottom 10,000 (or whatever `track_total_hits` is set to) values from the sort field. Signed-off-by: Michael Froh <froh@amazon.com>
|
{"run-benchmark-test": "id_14"} |
|
Invalid comment format or config id. Please refer to https://github.com/opensearch-project/OpenSearch/blob/main/PERFORMANCE_BENCHMARKS.md on how to run benchmarks on pull requests. |
Signed-off-by: Michael Froh <froh@amazon.com>
msfroh
force-pushed
the
approximate_MatchAllQuery_benchmark
branch
from
04a898c
to
2ba6819
Compare
|
{"run-benchmark-test": "id_14"} |
|
Invalid comment format or config id. Please refer to https://github.com/opensearch-project/OpenSearch/blob/main/PERFORMANCE_BENCHMARKS.md on how to run benchmarks on pull requests. |
|
❌ Gradle check result for 2ba6819: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR accompanies #16321 and adds a throwaway benchmark workload that enables range query approximation, to check if the changes there have the desired effect of reducing latency on
match_allqueries with asortover a numeric field.Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.